Prefer real paths over those with links for glob results #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
…-results Prefer real paths over those with links for glob results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before link resolution was done for ancestors, only leaf nodes in the file tree could be links. Now it is possible for ancestors of a path to have symlinks. This PR ensures that only the "real path" representation for a result (a path with no links) is surfaced during globbing, not necessarily the path matched against the glob pattern.
Also, the
source.Locationcurrently used to adapt tofile.Referencehas been enhanced to act as a more accurate key for content fetch requests by adding the resulting virtual path from the glob result onto the struct (which my have ancestor paths with symlinks).