Ensure java parent pkg ref isn't nil when looking for parent matches #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a927245 to
54f63bb
Compare
Signed-off-by: Dan Luhring <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
54f63bb to
bb1facb
Compare
Signed-off-by: Dan Luhring <[email protected]>
Signed-off-by: Dan Luhring <[email protected]>
alfredodeza
reviewed
Jan 27, 2021
| } | ||
|
|
||
| pkgKey := uniquePkgKey(&p) | ||
| if propsObj.Version != "" && propsObj.ArtifactID != "" { |
There was a problem hiding this comment.
is it possible to continue correctly if there is a Version but there is no ArtifactID ?
There was a problem hiding this comment.
@alfredodeza Fair question, tbh I'm not sure. This set of methods needs a lot of work: to simplify, to more clearly express business concerns, to reduce possible states, etc. I have a branch set to the side where I've started this, but wanted to keep the scope down for this impending release.
alfredodeza
approved these changes
Jan 27, 2021
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
Ensure java parent pkg ref isn't nil when looking for parent matches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #252 (and duplicate issue #291)
(this fix was provided by @wagoodman)
Signed-off-by: Alex Goodman [email protected]