fixed #4430 exclude dev pnpm pkg#4487
Merged
wagoodman merged 4 commits intoanchore:mainfrom Jan 7, 2026
Merged
Conversation
Signed-off-by: Rez Moss <[email protected]>
wagoodman
reviewed
Dec 22, 2025
Signed-off-by: Alex Goodman <[email protected]>
wagoodman
reviewed
Jan 5, 2026
Contributor
wagoodman
left a comment
There was a problem hiding this comment.
I've pushed a code change to use the existing option -- can you add a test to ensure we're honoring the option in the parser?
Signed-off-by: Rez Moss <[email protected]>
Signed-off-by: Rez Moss <[email protected]>
Contributor
Author
|
@wagoodman done |
wagoodman
approved these changes
Jan 7, 2026
levrik
reviewed
Jan 26, 2026
| type pnpmV9PackageEntry struct { | ||
| Resolution map[string]string `yaml:"resolution"` | ||
| PeerDependencies map[string]string `yaml:"peerDependencies"` | ||
| Dev bool `yaml:"dev"` |
There was a problem hiding this comment.
This flag does not exist in any of my lockfiles created by PNPM v9 or v10. I don't think this PR works!
Contributor
Author
There was a problem hiding this comment.
@levrik youre right, this PR just works for pnpm dev exclude for ver before v9,im working on exclusion for v9 and after, which needs a different approach, and will send a PR later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Exclude development or test dependencies for PNPM Package type
Type of change
Checklist
Issue references