Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Force UI teardown when event is sourced from a signal interrupt #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2021
Merged

Force UI teardown when event is sourced from a signal interrupt #453

merged 1 commit into from
Jun 29, 2021

Conversation

@wagoodman
Copy link
Contributor

This PR fixes the behavior in v0.18.0 where ctrl C does not appear to interrupt the application execution. When a signal interrupt is handled it is important that the UI is forcefully torn down, not waiting for any unfinished elements (e.g. spinners). This PR adds this forcing mechanism.

@wagoodman wagoodman added the bug Something isn't working label Jun 29, 2021
@wagoodman wagoodman requested a review from a team June 29, 2021 22:00
@wagoodman wagoodman self-assigned this Jun 29, 2021
@github-actions
Copy link

github-actions bot commented Jun 29, 2021 •
edited
Loading

Benchmark Test Results

Benchmark results from the latest changes vs base branch 
name                                                   old time/op    new time/op    delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2           795µs ± 5%     931µs ± 2%  +17.02%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2        1.10ms ± 7%    1.23ms ± 1%  +11.84%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2     415µs ± 2%     468µs ± 1%  +12.66%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                 387µs ± 3%     442µs ± 1%  +14.15%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                  416µs ± 5%     458µs ± 1%  +10.14%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                  5.51ms ± 7%    6.34ms ± 0%  +15.00%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                  584µs ± 5%     684µs ± 1%  +17.03%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-cataloger-2                     218µs ± 5%     246µs ± 3%  +13.08%  (p=0.008 n=5+5)
ImagePackageCatalogers/rust-cataloger-2                   318µs ± 3%     372µs ± 1%  +17.05%  (p=0.008 n=5+5)

name                                                   old alloc/op   new alloc/op   delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2          97.4kB ± 0%    97.5kB ± 0%     ~     (p=0.421 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2         579kB ± 0%     579kB ± 0%   -0.03%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2     112kB ± 0%     112kB ± 0%     ~     (p=0.794 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                 115kB ± 0%     115kB ± 0%     ~     (p=0.056 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                  134kB ± 0%     134kB ± 0%   +0.01%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                  1.79MB ± 0%    1.80MB ± 0%     ~     (p=0.151 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                 1.14MB ± 0%    1.14MB ± 0%     ~     (p=0.889 n=5+5)
ImagePackageCatalogers/go-cataloger-2                    53.9kB ± 0%    53.9kB ± 0%     ~     (p=0.690 n=5+5)
ImagePackageCatalogers/rust-cataloger-2                  88.9kB ± 0%    88.9kB ± 0%   +0.02%  (p=0.016 n=4+5)

name                                                   old allocs/op  new allocs/op  delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2           1.96k ± 0%     1.96k ± 0%     ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2         5.89k ± 0%     5.89k ± 0%     ~     (all equal)
ImagePackageCatalogers/javascript-package-cataloger-2     1.93k ± 0%     1.93k ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                 2.37k ± 0%     2.37k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                  3.19k ± 0%     3.19k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                   22.3k ± 0%     22.3k ± 0%     ~     (p=0.556 n=4+5)
ImagePackageCatalogers/apkdb-cataloger-2                  1.85k ± 0%     1.85k ± 0%     ~     (all equal)
ImagePackageCatalogers/go-cataloger-2                     1.44k ± 0%     1.44k ± 0%     ~     (all equal)
ImagePackageCatalogers/rust-cataloger-2                   2.75k ± 0%     2.75k ± 0%     ~     (all equal)

@wagoodman wagoodman merged commit 2de56c0 into main Jun 29, 2021
@wagoodman wagoodman deleted the force-etui-exit branch June 29, 2021 22:16
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@wagoodman
force UI teardown when event is sourced from a signal interrupt (anch…
55a0cf0 
…ore#453)

Signed-off-by: Alex Goodman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@luhring luhring luhring approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wagoodman wagoodman

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wagoodman @luhring