Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@wagoodman
Copy link
Contributor

@wagoodman wagoodman commented Aug 9, 2021

We have an integration test to ensure that we are using the latest license list, which is now failing since a new list was recently published (moments ago):

=== RUN   TestSPDXLicenseListIsTheLatest
    license_list_test.go:35: 
        	Error Trace:	license_list_test.go:35
        	Error:      	Not equal: 
        	            	expected: "3.14"
        	            	actual  : "3.13"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-3.14
        	            	+3.13
        	Test:       	TestSPDXLicenseListIsTheLatest

This PR updates the license list to the latest version (via go generate ./...)

@wagoodman wagoodman requested a review from a team August 9, 2021 19:11
@wagoodman wagoodman force-pushed the update-spdx-license-list branch from 6074bd3 to 36241a8 Compare August 9, 2021 19:12
@wagoodman wagoodman self-assigned this Aug 9, 2021
@github-actions
Copy link

github-actions bot commented Aug 9, 2021

Benchmark Test Results

Benchmark results from the latest changes vs base branch
name                                                   time/op
ImagePackageCatalogers/ruby-gemspec-cataloger-2         954µs ± 2%
ImagePackageCatalogers/python-package-cataloger-2      1.33ms ± 2%
ImagePackageCatalogers/javascript-package-cataloger-2   490µs ± 1%
ImagePackageCatalogers/dpkgdb-cataloger-2               483µs ± 3%
ImagePackageCatalogers/rpmdb-cataloger-2                510µs ± 4%
ImagePackageCatalogers/java-cataloger-2                6.52ms ± 1%
ImagePackageCatalogers/apkdb-cataloger-2                755µs ± 5%
ImagePackageCatalogers/go-cataloger-2                   267µs ± 3%
ImagePackageCatalogers/rust-cataloger-2                 390µs ± 2%

name                                                   alloc/op
ImagePackageCatalogers/ruby-gemspec-cataloger-2        97.6kB ± 0%
ImagePackageCatalogers/python-package-cataloger-2       579kB ± 0%
ImagePackageCatalogers/javascript-package-cataloger-2   112kB ± 0%
ImagePackageCatalogers/dpkgdb-cataloger-2               116kB ± 0%
ImagePackageCatalogers/rpmdb-cataloger-2                134kB ± 0%
ImagePackageCatalogers/java-cataloger-2                1.80MB ± 0%
ImagePackageCatalogers/apkdb-cataloger-2               1.14MB ± 0%
ImagePackageCatalogers/go-cataloger-2                  53.9kB ± 0%
ImagePackageCatalogers/rust-cataloger-2                88.9kB ± 0%

name                                                   allocs/op
ImagePackageCatalogers/ruby-gemspec-cataloger-2         1.96k ± 0%
ImagePackageCatalogers/python-package-cataloger-2       5.89k ± 0%
ImagePackageCatalogers/javascript-package-cataloger-2   1.93k ± 0%
ImagePackageCatalogers/dpkgdb-cataloger-2               2.37k ± 0%
ImagePackageCatalogers/rpmdb-cataloger-2                3.19k ± 0%
ImagePackageCatalogers/java-cataloger-2                 22.3k ± 0%
ImagePackageCatalogers/apkdb-cataloger-2                1.85k ± 0%
ImagePackageCatalogers/go-cataloger-2                   1.44k ± 0%
ImagePackageCatalogers/rust-cataloger-2                 2.75k ± 0%

@wagoodman wagoodman enabled auto-merge (squash) August 9, 2021 19:45
@wagoodman wagoodman merged commit 3a51689 into main Aug 9, 2021
@wagoodman wagoodman deleted the update-spdx-license-list branch August 9, 2021 19:47
@wagoodman wagoodman mentioned this pull request Aug 9, 2021
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
* update SPDX license list from 3.13 to 3.14

Signed-off-by: Alex Goodman <[email protected]>

* remove license list version from spdx snapshot unit tests

Signed-off-by: Alex Goodman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants