Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix go module tidy checks for release pipeline #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2021
Merged

Fix go module tidy checks for release pipeline #483

merged 1 commit into from
Aug 18, 2021

Conversation

@wagoodman
Copy link
Contributor

Closes #458

@wagoodman wagoodman requested a review from a team August 18, 2021 14:14
@wagoodman wagoodman self-assigned this Aug 18, 2021
@github-actions
Copy link

Benchmark Test Results

Benchmark results from the latest changes vs base branch 
name                                                   old time/op    new time/op    delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2           800µs ± 1%    1122µs ±18%  +40.19%  (p=0.016 n=4+5)
ImagePackageCatalogers/python-package-cataloger-2        1.13ms ± 0%    1.45ms ± 1%  +28.71%  (p=0.016 n=4+5)
ImagePackageCatalogers/javascript-package-cataloger-2     379µs ± 0%     512µs ± 2%  +34.86%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                 366µs ± 1%     491µs ± 1%  +34.13%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                  382µs ± 1%     523µs ± 1%  +36.81%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                  5.51ms ± 1%    7.17ms ± 2%  +30.08%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                  582µs ± 0%     733µs ± 1%  +26.11%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-cataloger-2                     199µs ± 1%     273µs ± 1%  +37.22%  (p=0.008 n=5+5)
ImagePackageCatalogers/rust-cataloger-2                   322µs ± 0%     431µs ± 2%  +33.78%  (p=0.008 n=5+5)

name                                                   old alloc/op   new alloc/op   delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2           138kB ± 0%     138kB ± 0%     ~     (p=0.151 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2         649kB ± 0%     650kB ± 0%   +0.05%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2     113kB ± 0%     113kB ± 0%   +0.19%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                 126kB ± 0%     126kB ± 0%   +0.20%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                  138kB ± 0%     138kB ± 0%   +0.00%  (p=0.016 n=5+4)
ImagePackageCatalogers/java-cataloger-2                  1.99MB ± 0%    1.99MB ± 0%     ~     (p=0.095 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                 1.16MB ± 0%    1.16MB ± 0%     ~     (p=0.413 n=5+5)
ImagePackageCatalogers/go-cataloger-2                    55.5kB ± 0%    55.7kB ± 0%   +0.28%  (p=0.008 n=5+5)
ImagePackageCatalogers/rust-cataloger-2                   109kB ± 0%     109kB ± 0%   -0.01%  (p=0.000 n=4+5)

name                                                   old allocs/op  new allocs/op  delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2           2.12k ± 0%     2.12k ± 0%     ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2         6.45k ± 0%     6.45k ± 0%     ~     (p=0.556 n=4+5)
ImagePackageCatalogers/javascript-package-cataloger-2     1.92k ± 0%     1.92k ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                 2.39k ± 0%     2.39k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                  3.19k ± 0%     3.19k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                   23.7k ± 0%     23.7k ± 0%     ~     (p=0.246 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                  1.91k ± 0%     1.91k ± 0%     ~     (all equal)
ImagePackageCatalogers/go-cataloger-2                     1.44k ± 0%     1.44k ± 0%     ~     (all equal)
ImagePackageCatalogers/rust-cataloger-2                   2.81k ± 0%     2.81k ± 0%     ~     (all equal)

luhring
luhring approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@luhring luhring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@wagoodman wagoodman merged commit b0e9b92 into main Aug 18, 2021
@wagoodman wagoodman deleted the fix-gomod-gosum-validation branch August 18, 2021 15:00
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@wagoodman
Merge pull request anchore#483 from anchore/fix-gomod-gosum-validation
b5cbcd7 
Fix go module tidy checks for release pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@luhring luhring luhring approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wagoodman wagoodman

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pipelines allow unclean go.sum files that block our release pipeline

3 participants

@wagoodman @luhring