Add support for older CentOS versions (6 & 5) by checking additional release files for information #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6ab349d to
60b89d6
Compare
Benchmark Test ResultsBenchmark results from the latest changes vs base branch |
wagoodman
reviewed
Aug 23, 2021
| } | ||
|
|
||
| // example CPE: cpe:/o:centos:linux:6:GA | ||
| var systemReleaseCpeMatcher = regexp.MustCompile(`cpe:\/o:(.*?):.*?:(.*?):.*?$`) |
There was a problem hiding this comment.
This is a good approach, however, syft already has CPE parsing built in that we can leverage https://github.com/anchore/syft/blob/main/syft/pkg/cpe.go#L12 --can we switch to using this?
There was a problem hiding this comment.
@wagoodman Just tried that, but it creates an import cycle :(. Unless i'm doing something horribly wrong?
There was a problem hiding this comment.
nope, you are not doing anything wrong --it looks like pkg depends on distro to support pURLs. This hints at a refactor that we can do later, either striving for pkg to not depend on distro (medium lift-ish) or migrating cpe out of pkg (small lift). We can defer that for now.
Can you leave a comment in the code that points out we should use the CPE parser once it is importable? (no code change requested at this point 👍 )
wagoodman
approved these changes
Sep 1, 2021
…release files for information Signed-off-by: Samuel Dacanay <[email protected]>
60b89d6 to
b05748d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #429
Signed-off-by: Samuel Dacanay [email protected]