Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Updated the distro package to include SLES #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2021
Merged

Updated the distro package to include SLES #489

merged 1 commit into from
Aug 23, 2021

Conversation

@Toure
Copy link
Contributor

@Toure Toure commented Aug 23, 2021

This change will add SLES distribution to the type package to allow syft to scan for rpm packages, this PR does not include the changes needed to read the new sqlite3 rpmDB format.

Signed-off-by: Toure Dunnon [email protected]

@github-actions
Copy link

github-actions bot commented Aug 23, 2021 •
edited
Loading

Benchmark Test Results

Benchmark results from the latest changes vs base branch 
name                                                   old time/op    new time/op    delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2           809µs ± 1%     916µs ± 3%  +13.24%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2        1.14ms ± 0%    1.45ms ±28%  +27.43%  (p=0.016 n=4+5)
ImagePackageCatalogers/javascript-package-cataloger-2     384µs ± 1%     444µs ± 1%  +15.57%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                 369µs ± 1%     399µs ± 2%   +7.97%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                  387µs ± 1%     430µs ± 4%  +11.01%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                  5.44ms ± 1%    5.95ms ± 6%   +9.44%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                  582µs ± 0%     603µs ± 1%   +3.66%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-cataloger-2                     201µs ± 2%     221µs ± 2%  +10.07%  (p=0.008 n=5+5)
ImagePackageCatalogers/rust-cataloger-2                   325µs ± 0%     349µs ± 1%   +7.34%  (p=0.008 n=5+5)

name                                                   old alloc/op   new alloc/op   delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2           138kB ± 0%     138kB ± 0%   +0.16%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2         649kB ± 0%     650kB ± 0%     ~     (p=0.095 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2     113kB ± 0%     113kB ± 0%   +0.23%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                 126kB ± 0%     126kB ± 0%   +0.13%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                  138kB ± 0%     138kB ± 0%   +0.00%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                  1.99MB ± 0%    1.99MB ± 0%   +0.29%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                 1.16MB ± 0%    1.16MB ± 0%     ~     (p=0.270 n=5+5)
ImagePackageCatalogers/go-cataloger-2                    55.5kB ± 0%    55.7kB ± 0%   +0.38%  (p=0.008 n=5+5)
ImagePackageCatalogers/rust-cataloger-2                   109kB ± 0%     109kB ± 0%     ~     (p=0.238 n=4+5)

name                                                   old allocs/op  new allocs/op  delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2           2.12k ± 0%     2.12k ± 0%     ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2         6.45k ± 0%     6.45k ± 0%     ~     (p=0.556 n=5+4)
ImagePackageCatalogers/javascript-package-cataloger-2     1.92k ± 0%     1.92k ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                 2.39k ± 0%     2.39k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                  3.19k ± 0%     3.19k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                   23.7k ± 0%     23.7k ± 0%     ~     (p=0.484 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                  1.91k ± 0%     1.91k ± 0%   +0.05%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-cataloger-2                     1.44k ± 0%     1.44k ± 0%     ~     (all equal)
ImagePackageCatalogers/rust-cataloger-2                   2.81k ± 0%     2.81k ± 0%     ~     (all equal)

Updated the distro package to include SLES type to expand support, th…
0f0fe59 
…is change will not include the new sqlite3 rpmDB format

Signed-off-by: Toure Dunnon <[email protected]>
@Toure Toure force-pushed the SLES_support_berkeleyDB branch from 1f729a2 to 0f0fe59 Compare August 23, 2021 19:05
@Toure Toure merged commit 9acabb8 into main Aug 23, 2021
@Toure Toure deleted the SLES_support_berkeleyDB branch August 23, 2021 20:14
@wagoodman wagoodman added the enhancement New feature or request label Sep 13, 2021
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Merge pull request anchore#489 from anchore/SLES_support_berkeleyDB
5b20e59 
Updated the distro package to include SLES
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wagoodman wagoodman wagoodman approved these changes

@rbrady rbrady Awaiting requested review from rbrady

@zhill zhill Awaiting requested review from zhill

@dakaneye dakaneye Awaiting requested review from dakaneye

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Toure @wagoodman