Add for known bad CPE field combinations for jenkins package #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a6b630d to
00c3ab4
Compare
Benchmark Test ResultsBenchmark results from the latest changes vs base branch |
00c3ab4 to
ae55e5d
Compare
Signed-off-by: Alex Goodman <[email protected]>
ae55e5d to
18af21d
Compare
luhring
approved these changes
Apr 22, 2021
| // jira / atlassian should not apply to clients | ||
| if cpe.Vendor == "atlassian" && cpe.Product == "jira" && strings.Contains(p.Name, "client") { | ||
| return true | ||
| if cpe.Product == "jira" && strings.Contains(strings.ToLower(p.Name), "client") { |
There was a problem hiding this comment.
nit: Now that we're amassing some nontrivial, specialized rules in our list of filterFn, it would be nice to codify these as named functions that get referenced here in this list. But I'm making this a "nit" due to the context of our CPE implementation future
There was a problem hiding this comment.
agreed with the long term approach, and held off for similar considerations 👍
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
Add for known bad CPE field combinations for jenkins package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a filter to eliminate guesses that would result in matching jenkins server without having a package name that minimally reflects this.
Additionally updates the jira filter to consider
wfn.Anyvendor values.