Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Align check names to release quality gate #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2021
Merged

Align check names to release quality gate #406

merged 1 commit into from
Apr 22, 2021

Conversation

@wagoodman
Copy link
Contributor

@wagoodman wagoodman commented Apr 22, 2021 •
edited
Loading

Currently the release pipeline will not complete; the job names are tied to the name: attribute, not the yaml section name, which means the quality gate checks need to be adjusted to match.

@wagoodman wagoodman requested a review from a team April 22, 2021 20:21
@wagoodman wagoodman self-assigned this Apr 22, 2021
@github-actions
Copy link

Benchmark Test Results

Benchmark results from the latest changes vs base branch 
name                                                   old time/op    new time/op    delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2          1.03ms ± 1%    0.92ms ± 3%  -10.85%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2        1.40ms ± 2%    1.24ms ± 3%  -11.24%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2     535µs ± 2%     472µs ± 2%  -11.71%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                 511µs ± 1%     442µs ± 2%  -13.66%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                  546µs ± 3%     467µs ± 2%  -14.53%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                  7.09ms ± 1%    6.16ms ± 2%  -13.13%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                  731µs ± 1%     670µs ± 3%   -8.34%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-cataloger-2                     268µs ± 1%     232µs ± 1%  -13.56%  (p=0.008 n=5+5)
ImagePackageCatalogers/rust-cataloger-2                   427µs ± 2%     364µs ± 3%  -14.68%  (p=0.008 n=5+5)

name                                                   old alloc/op   new alloc/op   delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2          97.5kB ± 0%    97.3kB ± 0%   -0.19%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2         579kB ± 0%     579kB ± 0%   -0.04%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2     112kB ± 0%     111kB ± 0%     ~     (p=0.056 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                 115kB ± 0%     115kB ± 0%   -0.12%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                  134kB ± 0%     134kB ± 0%   -0.01%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                  1.78MB ± 0%    1.78MB ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                 1.14MB ± 0%    1.14MB ± 0%     ~     (p=0.151 n=5+5)
ImagePackageCatalogers/go-cataloger-2                    48.4kB ± 0%    48.3kB ± 0%   -0.15%  (p=0.032 n=5+5)
ImagePackageCatalogers/rust-cataloger-2                  88.9kB ± 0%    88.9kB ± 0%   -0.01%  (p=0.000 n=5+4)

name                                                   old allocs/op  new allocs/op  delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2           1.96k ± 0%     1.96k ± 0%     ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2         5.88k ± 0%     5.88k ± 0%     ~     (all equal)
ImagePackageCatalogers/javascript-package-cataloger-2     1.93k ± 0%     1.93k ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                 2.37k ± 0%     2.37k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                  3.19k ± 0%     3.19k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                   22.3k ± 0%     22.3k ± 0%     ~     (all equal)
ImagePackageCatalogers/apkdb-cataloger-2                  1.85k ± 0%     1.85k ± 0%     ~     (all equal)
ImagePackageCatalogers/go-cataloger-2                     1.40k ± 0%     1.40k ± 0%     ~     (all equal)
ImagePackageCatalogers/rust-cataloger-2                   2.74k ± 0%     2.74k ± 0%     ~     (all equal)

@wagoodman wagoodman enabled auto-merge April 22, 2021 20:37
@wagoodman wagoodman merged commit 032cecb into main Apr 22, 2021
@wagoodman wagoodman deleted the align-check-names-to-quality-gate branch April 22, 2021 20:38
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@wagoodman
Merge pull request anchore#406 from anchore/align-check-names-to-qual…
70fbfd3 
…ity-gate

Align check names to release quality gate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alfredodeza alfredodeza alfredodeza approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wagoodman wagoodman

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wagoodman @alfredodeza