feat: Enable .rar files for Java resource adapters to be cataloged. #4137
Conversation
Signed-off-by: Marc Thomas <[email protected]>
| // LifeRay makes it pretty cumbersome to make a such plugins; their docs are | ||
| // out of date, and they charge for their IDE. If you find an example | ||
| // project that we can build in CI feel free to include it | ||
| "**/*.rar", // Java Resource Adapter Archive |
There was a problem hiding this comment.
Is this going to cause a problem when Win RAR archives are encountered?
There was a problem hiding this comment.
An unexpected format (which I believe can happen with any file extension) will cause a 'not valid zip file' DEBUG message, and further processing of this file is stopped. See the example log entry in DEBUG mode when I provide a WinRAR file.
[0005] DEBUG cannot find beginning of zip archive="/tmp/syft-archive-contents-469710021/archive-testfile.rar3.rar" : zip: not a valid zip file
[0005] DEBUG unable to open zip archive (/tmp/syft-archive-contents-469710021/archive-testfile.rar3.rar): zip: not a valid zip file
|
Hey @thomassui it looks like there are test failures, are you able to have a look? |
Signed-off-by: Marc Thomas <[email protected]>
|
Hey @kzantow, I investigated the failing unit test and fixed it. I’ll do better next time. |
Description
Syft catalogs ".rar" Java resource adapter files.
Type of change
Checklist: