fix: return PanicErrors #4294
Draft
fix: return PanicErrors #4294
+25
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
wagoodman
reviewed
Oct 20, 2025
| return errors.Join(out...) | ||
| } | ||
| // handle PanicErrors directly, since these are wrapped errors | ||
| if e, ok := err.(sync.PanicError); ok { |
There was a problem hiding this comment.
This function recursively unwraps errors, it doesn't need to let errors.As also do this
wagoodman
reviewed
Oct 20, 2025
| prefix := strings.TrimSuffix(err.Error(), wrapped.Error()) | ||
| return fmt.Errorf("%s%w", prefix, got) | ||
| // if there is not a wrapped error, fall through to visit the error directly | ||
| if wrapped != nil { |
There was a problem hiding this comment.
nit / non-blocking: this would be a little more readable with a guard clause instead of wrapping (e.g. instead do if wrapped == nil { return nil} ahead of the remaining logic.)
There was a problem hiding this comment.
It's a little different behavior than this -- if wrapped is nil, it continues to visit the container
wagoodman
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
go-synclibrary to return panics as errors during concurrent calls, and adds an option to loudly log, but not fail on errors. This option will allow users to opt in to behavior in their CI environment, for example, that errors including panics will not cause the process to return nonzero, but instead only be error logged.Type of change
Checklist:
TODO:
--continue-on-erroror similar