Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@luhring
Copy link
Contributor

@luhring luhring commented Sep 24, 2021

Signed-off-by: Dan Luhring [email protected]

@luhring luhring requested a review from a team September 24, 2021 15:37
@github-actions
Copy link

Benchmark Test Results

Benchmark results from the latest changes vs base branch
name                                                   old time/op    new time/op    delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2          1.09ms ± 3%    0.96ms ± 4%  -11.76%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2        1.63ms ± 3%    1.54ms ± 1%   -5.26%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2     505µs ± 2%     462µs ± 1%   -8.54%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                 507µs ± 2%     452µs ± 4%  -10.88%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                  518µs ± 1%     457µs ± 3%  -11.62%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                  10.3ms ± 2%     9.6ms ± 2%   -6.36%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                  815µs ± 1%     742µs ± 2%   -9.02%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-cataloger-2                     265µs ± 1%     234µs ± 5%  -11.66%  (p=0.008 n=5+5)
ImagePackageCatalogers/rust-cataloger-2                   463µs ± 4%     416µs ± 4%  -10.05%  (p=0.008 n=5+5)

name                                                   old alloc/op   new alloc/op   delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2           144kB ± 0%     143kB ± 0%   -0.18%  (p=0.016 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2         715kB ± 0%     715kB ± 0%   -0.06%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2     118kB ± 0%     118kB ± 0%   -0.36%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                 133kB ± 0%     132kB ± 0%   -0.41%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                  140kB ± 0%     140kB ± 0%   +0.00%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                  2.69MB ± 0%    2.69MB ± 0%     ~     (p=0.690 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                 1.17MB ± 0%    1.17MB ± 0%     ~     (p=0.389 n=5+5)
ImagePackageCatalogers/go-cataloger-2                    55.0kB ± 0%    54.7kB ± 0%   -0.53%  (p=0.008 n=5+5)
ImagePackageCatalogers/rust-cataloger-2                   121kB ± 0%     121kB ± 0%   -0.00%  (p=0.024 n=5+5)

name                                                   old allocs/op  new allocs/op  delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2           2.33k ± 0%     2.33k ± 0%     ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2         8.11k ± 0%     8.11k ± 0%     ~     (p=0.333 n=5+4)
ImagePackageCatalogers/javascript-package-cataloger-2     1.99k ± 0%     1.99k ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                 2.53k ± 0%     2.53k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                  3.24k ± 0%     3.24k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                   36.1k ± 0%     36.1k ± 0%     ~     (p=0.524 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                  2.27k ± 0%     2.27k ± 0%     ~     (all equal)
ImagePackageCatalogers/go-cataloger-2                     1.46k ± 0%     1.46k ± 0%     ~     (all equal)
ImagePackageCatalogers/rust-cataloger-2                   3.09k ± 0%     3.09k ± 0%     ~     (all equal)

Copy link
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@luhring luhring merged commit d1ac476 into main Sep 24, 2021
@luhring luhring deleted the update-readme branch September 24, 2021 15:42
spiffcs added a commit that referenced this pull request Sep 30, 2021
* main:
  Add vendor + product known good CPE field values (#517)
  Add SBOM to releases (#500)
  Add announcement for KubeCon meetup (#515)
  Prevent invalid CPE field values (#514)
  Filter out CPE product candidates that are asterisks (#513)
  Use Anchore fork of packageurl lib without replace directive (#512)
  update log file permissions to 0644 (#511)

Signed-off-by: Christopher Angelo Phillips <[email protected]>
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants