-
Couldn't load subscription status.
- Fork 727
Adds composer installed.json parser #643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the PR @bomoko! I'll take a look when I have some free cycles. |
|
One last change is needed before we can merge this, @bomoko; we require that all commits are signed before merging into the baseline (see CONTRIBUTING.md) . Shout out if you have any questions about this! |
|
Thanks so much @wagoodman - I think I understand how to sign the previous commits if I rebase and amend with Is it a problem that I end up signing your commits? Or do the commits simply need to be signed? |
|
@bomoko indeed rebasing with |
Signed-off-by: Blaize Kaye <[email protected]>
Signed-off-by: Blaize Kaye <[email protected]>
Signed-off-by: Blaize Kaye <[email protected]>
Signed-off-by: Blaize Kaye <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
|
Awesome, thanks @wagoodman - since signing the commit changes the hashes, I think I'm going to need to push force the branch to get the history right. Any objections? (I can also open a new PR) Edit: Let me just do it - if it's a faux pas I'll open up a new PR ;) |
3488526 to
6384863
Compare
|
@bomoko force push away! Our take on this is that commits on development branches are up to the author, so you can rearrange as you like. We tend to squash merge PRs into main in the end. |
* Adds installed.json functionality and tests Signed-off-by: Blaize Kaye <[email protected]> * Adds php-installed-cataloger Signed-off-by: Blaize Kaye <[email protected]> * Changes fallback logic Signed-off-by: Blaize Kaye <[email protected]> * Adds image tests for installed.json composer packages Signed-off-by: Blaize Kaye <[email protected]> * tweak PHP cataloger names Signed-off-by: Alex Goodman <[email protected]> * unexport PHP types and fix CLI tests Signed-off-by: Alex Goodman <[email protected]> * rename PHP cataloger file Signed-off-by: Alex Goodman <[email protected]> Co-authored-by: Alex Goodman <[email protected]> Signed-off-by: fsl <[email protected]>
* Adds installed.json functionality and tests Signed-off-by: Blaize Kaye <[email protected]> * Adds php-installed-cataloger Signed-off-by: Blaize Kaye <[email protected]> * Changes fallback logic Signed-off-by: Blaize Kaye <[email protected]> * Adds image tests for installed.json composer packages Signed-off-by: Blaize Kaye <[email protected]> * tweak PHP cataloger names Signed-off-by: Alex Goodman <[email protected]> * unexport PHP types and fix CLI tests Signed-off-by: Alex Goodman <[email protected]> * rename PHP cataloger file Signed-off-by: Alex Goodman <[email protected]> Co-authored-by: Alex Goodman <[email protected]>
closes #642
This is, as far as possible, a copy-pasta from the earlier PHP composer.lock parser. I'm still new to the code base, so I've tried to work out what needs to be changed/added, etc.
Thanks for taking the time to look at this.
signed off by Blaize M. Kaye: [email protected]