Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix M1 install #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 14, 2021
Merged

Fix M1 install #686

merged 2 commits into from
Dec 14, 2021

Conversation

@wagoodman
Copy link
Contributor

Closes #684

@wagoodman wagoodman requested a review from a team December 14, 2021 15:22
@github-actions
Copy link

github-actions bot commented Dec 14, 2021 •
edited
Loading

Benchmark Test Results

Benchmark results from the latest changes vs base branch 
name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2              1.52ms ± 3%    1.86ms ± 1%  +22.90%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            3.66ms ± 5%    4.81ms ± 7%  +31.50%  (p=0.008 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2    1.12ms ± 4%    1.38ms ± 1%  +23.04%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         904µs ± 2%    1118µs ± 3%  +23.61%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                    1.07ms ± 4%    1.35ms ± 3%  +26.95%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      923µs ± 2%    1129µs ± 1%  +22.27%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      12.2ms ± 3%    14.6ms ± 1%  +20.09%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.38ms ± 6%    1.76ms ± 4%  +27.67%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          1.84µs ± 8%    2.19µs ± 2%  +19.12%  (p=0.008 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2               296kB ± 0%     297kB ± 0%   +0.17%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            1.32MB ± 0%    1.32MB ± 0%     ~     (p=0.151 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     282kB ± 0%     282kB ± 0%     ~     (p=0.690 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         222kB ± 0%     222kB ± 0%   +0.13%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     281kB ± 0%     281kB ± 0%     ~     (p=0.690 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      245kB ± 0%     245kB ± 0%   +0.01%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      3.41MB ± 0%    3.41MB ± 0%     ~     (p=0.841 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.36MB ± 0%    1.36MB ± 0%   +0.00%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            560B ± 0%      560B ± 0%     ~     (all equal)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2               9.32k ± 0%     9.32k ± 0%     ~     (p=0.238 n=5+4)
ImagePackageCatalogers/python-package-cataloger-2             39.7k ± 0%     39.7k ± 0%     ~     (p=0.270 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     9.74k ± 0%     9.74k ± 0%     ~     (p=0.444 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         6.21k ± 0%     6.21k ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                     8.99k ± 0%     8.99k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                      7.50k ± 0%     7.50k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                       68.8k ± 0%     68.8k ± 0%     ~     (p=0.968 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      11.6k ± 0%     11.6k ± 0%     ~     (p=0.794 n=4+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            13.0 ± 0%      13.0 ± 0%     ~     (all equal)

kzantow
kzantow approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wagoodman wagoodman enabled auto-merge (squash) December 14, 2021 15:50
@wagoodman wagoodman merged commit 3d8c166 into main Dec 14, 2021
@wagoodman wagoodman deleted the fix-m1-install branch December 14, 2021 15:54
spiffcs pushed a commit that referenced this pull request Jan 4, 2022
@wagoodman @spiffcs
Fix M1 install (#686)
8e07cb6 
* M1 install.sh script should use zip

Signed-off-by: Alex Goodman <[email protected]>

* add arm64 binary extraction

Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Christopher Angelo Phillips <[email protected]>
spiffcs pushed a commit that referenced this pull request Jan 4, 2022
@wagoodman @spiffcs
Fix M1 install (#686)
035c9eb 
* M1 install.sh script should use zip

Signed-off-by: Alex Goodman <[email protected]>

* add arm64 binary extraction

Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Christopher Angelo Phillips <[email protected]>
fengshunli pushed a commit to fengshunli/syft that referenced this pull request Jan 24, 2022
@wagoodman @fengshunli
Fix M1 install (anchore#686)
983050c 
* M1 install.sh script should use zip

Signed-off-by: Alex Goodman <[email protected]>

* add arm64 binary extraction

Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: fsl <[email protected]>
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@wagoodman
Fix M1 install (anchore#686)
2ba92fe 
* M1 install.sh script should use zip

Signed-off-by: Alex Goodman <[email protected]>

* add arm64 binary extraction

Signed-off-by: Alex Goodman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzantow kzantow kzantow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Installation via install.sh on Mac M1 is not working

2 participants

@wagoodman @kzantow