Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Handle extra empty lines in Java manifest parsing #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 14, 2021
Merged

Handle extra empty lines in Java manifest parsing #687

merged 2 commits into from
Dec 14, 2021

Conversation

@luhring
Copy link
Contributor

@luhring luhring commented Dec 14, 2021

@wagoodman wagoodman added the bug Something isn't working label Dec 14, 2021
wagoodman
wagoodman approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@wagoodman wagoodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This addresses the cases that the issue covers, I'll follow up with a PR that covers a few more

@luhring luhring merged commit 85ac5bc into anchore:main Dec 14, 2021
@luhring luhring deleted the fix-java-manifest-parsing branch December 14, 2021 16:56
spiffcs pushed a commit that referenced this pull request Jan 4, 2022
@luhring @spiffcs
Handle extra empty lines in Java manifest parsing (#687)
f6b6094 
* Add failing test for extra empty lines in manifest

Signed-off-by: Dan Luhring <[email protected]>

* Handle extra empty lines in Java manifests

Signed-off-by: Dan Luhring <[email protected]>
Signed-off-by: Christopher Angelo Phillips <[email protected]>
spiffcs pushed a commit that referenced this pull request Jan 4, 2022
@luhring @spiffcs
Handle extra empty lines in Java manifest parsing (#687)
ee8bc94 
* Add failing test for extra empty lines in manifest

Signed-off-by: Dan Luhring <[email protected]>

* Handle extra empty lines in Java manifests

Signed-off-by: Dan Luhring <[email protected]>
Signed-off-by: Christopher Angelo Phillips <[email protected]>
fengshunli pushed a commit to fengshunli/syft that referenced this pull request Jan 24, 2022
@luhring @fengshunli
Handle extra empty lines in Java manifest parsing (anchore#687)
6aa9b2e 
* Add failing test for extra empty lines in manifest

Signed-off-by: Dan Luhring <[email protected]>

* Handle extra empty lines in Java manifests

Signed-off-by: Dan Luhring <[email protected]>
Signed-off-by: fsl <[email protected]>
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@luhring
Handle extra empty lines in Java manifest parsing (anchore#687)
442a3ae 
* Add failing test for extra empty lines in manifest

Signed-off-by: Dan Luhring <[email protected]>

* Handle extra empty lines in Java manifests

Signed-off-by: Dan Luhring <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wagoodman wagoodman wagoodman approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@luhring @wagoodman