Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix repackaging of release archive for notarization #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2022
Merged

Fix repackaging of release archive for notarization #792

merged 1 commit into from
Feb 4, 2022

Conversation

@wagoodman
Copy link
Contributor

@wagoodman wagoodman commented Feb 4, 2022 •
edited
Loading

To prevent: https://github.com/anchore/syft/runs/5070963673?check_suite_focus=true

Task: notarizing binaries found in the release archive

zip error: Internal logic error (empty name without -j or -r)
error: cannot find payload for notarization: /Users/runner/work/syft/syft/dist/syft_0.37.1_darwin_amd64.zip

@wagoodman wagoodman changed the title repackage all file in notarization temp dir (not from tar output) Fix repackaging of release archive for notarization Feb 4, 2022
@wagoodman wagoodman requested a review from a team February 4, 2022 18:53
@wagoodman wagoodman self-assigned this Feb 4, 2022
@wagoodman wagoodman enabled auto-merge (squash) February 4, 2022 18:54
@github-actions
Copy link

github-actions bot commented Feb 4, 2022

Benchmark Test Results

Benchmark results from the latest changes vs base branch 
name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2              1.33ms ± 3%    1.67ms ± 5%  +25.34%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            3.08ms ± 8%    3.94ms ±19%  +27.78%  (p=0.008 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2    1.08ms ± 1%    1.27ms ± 3%  +17.43%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         834µs ± 5%    1018µs ± 7%  +21.94%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     966µs ± 3%    1219µs ± 8%  +26.17%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      882µs ± 2%    1061µs ± 5%  +20.28%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      13.8ms ± 3%    16.7ms ± 5%  +20.71%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.32ms ± 1%    1.58ms ±10%  +20.04%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          1.95µs ±10%    2.15µs ± 5%  +10.52%  (p=0.008 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2               253kB ± 0%     253kB ± 0%   +0.22%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            1.07MB ± 0%    1.07MB ± 0%     ~     (p=0.056 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     253kB ± 0%     254kB ± 0%   +0.19%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         208kB ± 0%     208kB ± 0%   +0.24%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     254kB ± 0%     255kB ± 0%   +0.27%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      236kB ± 0%     236kB ± 0%   +0.13%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      3.78MB ± 0%    3.79MB ± 0%     ~     (p=0.056 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.30MB ± 0%    1.30MB ± 0%   +0.09%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            560B ± 0%      560B ± 0%     ~     (all equal)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2               6.33k ± 0%     6.33k ± 0%     ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2             21.4k ± 0%     21.4k ± 0%     ~     (p=0.841 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     7.26k ± 0%     7.26k ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         5.36k ± 0%     5.36k ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                     7.11k ± 0%     7.11k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                      6.83k ± 0%     6.83k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                       74.7k ± 0%     74.7k ± 0%     ~     (p=0.143 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      7.38k ± 0%     7.38k ± 0%     ~     (p=0.365 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            13.0 ± 0%      13.0 ± 0%     ~     (all equal)

@wagoodman wagoodman merged commit d346980 into main Feb 4, 2022
@wagoodman wagoodman deleted the fix-notarize-repackage branch February 4, 2022 19:04
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@wagoodman
repackage all file in notarization temp dir (not from tar output) (an…
4aafa7f 
…chore#792)

Signed-off-by: Alex Goodman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@luhring luhring luhring approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wagoodman wagoodman

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wagoodman @luhring