Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Migrate mac binary signing as post-build step #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2022
Merged

Migrate mac binary signing as post-build step #803

merged 1 commit into from
Feb 7, 2022

Conversation

@wagoodman
Copy link
Contributor

The goreleaser signs step will not work for us as expected since:

  1. we are releasing archives and not binaries, so we need to repackage the archive that contains the release binary
  2. the signs step expects a signature file as output --replacing an existing asset will result in duplicate assets.

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Benchmark Test Results

Benchmark results from the latest changes vs base branch 
name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2              1.76ms ± 3%    1.54ms ± 5%  -12.56%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            4.00ms ± 2%    3.50ms ± 4%  -12.39%  (p=0.008 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2    1.36ms ± 1%    1.20ms ± 5%  -11.68%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2        1.09ms ± 3%    0.94ms ± 3%  -13.49%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                    1.25ms ± 1%    1.08ms ± 1%  -13.44%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                     1.17ms ± 5%    0.97ms ± 1%  -16.90%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      18.0ms ± 2%    15.3ms ± 2%  -15.03%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.70ms ± 4%    1.43ms ± 2%  -15.91%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          2.36µs ± 1%    2.14µs ± 6%   -9.33%  (p=0.008 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2               253kB ± 0%     253kB ± 0%   -0.33%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            1.07MB ± 0%    1.06MB ± 0%   -0.14%  (p=0.032 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     254kB ± 0%     253kB ± 0%   -0.19%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         208kB ± 0%     208kB ± 0%   -0.19%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     255kB ± 0%     254kB ± 0%   -0.23%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      236kB ± 0%     236kB ± 0%     ~     (p=0.056 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      3.79MB ± 0%    3.78MB ± 0%     ~     (p=0.151 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.30MB ± 0%    1.30MB ± 0%   -0.13%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            560B ± 0%      560B ± 0%     ~     (all equal)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2               6.33k ± 0%     6.33k ± 0%     ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2             21.4k ± 0%     21.4k ± 0%     ~     (p=0.357 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     7.26k ± 0%     7.26k ± 0%     ~     (p=0.762 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         5.36k ± 0%     5.36k ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                     7.11k ± 0%     7.11k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                      6.83k ± 0%     6.83k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                       74.7k ± 0%     74.7k ± 0%     ~     (p=0.246 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      7.38k ± 0%     7.38k ± 0%     ~     (p=0.397 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            13.0 ± 0%      13.0 ± 0%     ~     (all equal)

@wagoodman wagoodman merged commit 2c62651 into main Feb 7, 2022
@wagoodman wagoodman deleted the move-sign-to-post-build branch February 7, 2022 21:55
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@wagoodman
run signing as post-build step (anchore#803)
7496d63 
Signed-off-by: Alex Goodman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spiffcs spiffcs spiffcs approved these changes

+1 more reviewer

@luhring luhring luhring approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wagoodman @luhring @spiffcs