Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Serialize notarization steps #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2022
Merged

Serialize notarization steps #806

merged 1 commit into from
Feb 7, 2022

Conversation

@wagoodman
Copy link
Contributor

As far as I can tell from https://github.com/anchore/syft/runs/5100741150?check_suite_focus=true it seems that the notarization succeeds for one asset and fails for another asset. Notarization is supported for all architectures and the archive being submitted is prepared by the same script in either case. This PR restricts the release process to have no parallelism, which should result in a single notarization occurring at a time.

@wagoodman
serialize notarization
ad76bf3 
Signed-off-by: Alex Goodman <[email protected]>
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Benchmark Test Results

Benchmark results from the latest changes vs base branch 
name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2              1.36ms ± 1%    1.40ms ± 0%  +2.52%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            3.12ms ± 1%    3.19ms ± 5%    ~     (p=0.690 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2    1.07ms ± 0%    1.02ms ± 4%  -4.01%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         843µs ± 1%     804µs ± 4%  -4.60%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     974µs ± 1%     928µs ± 4%  -4.80%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      878µs ± 0%     874µs ± 4%    ~     (p=0.690 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      13.9ms ± 1%    13.0ms ± 5%  -6.03%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.29ms ± 1%    1.26ms ± 4%  -2.56%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          1.98µs ± 1%    1.96µs ± 7%    ~     (p=0.841 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2               253kB ± 0%     253kB ± 0%    ~     (p=0.548 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            1.06MB ± 0%    1.06MB ± 0%    ~     (p=1.000 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     253kB ± 0%     253kB ± 0%    ~     (p=0.548 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         208kB ± 0%     208kB ± 0%    ~     (p=0.151 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     254kB ± 0%     254kB ± 0%    ~     (p=0.151 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      236kB ± 0%     236kB ± 0%    ~     (p=0.151 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      3.77MB ± 0%    3.78MB ± 0%  +0.26%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.30MB ± 0%    1.30MB ± 0%    ~     (p=0.841 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            560B ± 0%      560B ± 0%    ~     (all equal)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2               6.33k ± 0%     6.33k ± 0%    ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2             21.4k ± 0%     21.4k ± 0%    ~     (p=0.579 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     7.26k ± 0%     7.26k ± 0%    ~     (p=1.000 n=5+4)
ImagePackageCatalogers/javascript-package-cataloger-2         5.36k ± 0%     5.36k ± 0%    ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                     7.11k ± 0%     7.11k ± 0%    ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                      6.83k ± 0%     6.83k ± 0%    ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                       74.7k ± 0%     74.7k ± 0%    ~     (p=0.857 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      7.38k ± 0%     7.38k ± 0%    ~     (p=0.444 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            13.0 ± 0%      13.0 ± 0%    ~     (all equal)

@wagoodman wagoodman enabled auto-merge (squash) February 7, 2022 23:46
@wagoodman wagoodman merged commit 0ed2842 into main Feb 7, 2022
@wagoodman wagoodman deleted the serialized-release branch February 7, 2022 23:47
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@wagoodman
serialize notarization (anchore#806)
128b7d7 
Signed-off-by: Alex Goodman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@luhring luhring luhring approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wagoodman @luhring