Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bump strset version to fix 386 builds #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2022
Merged

bump strset version to fix 386 builds #911

merged 1 commit into from
Mar 23, 2022

Conversation

@wagoodman
Copy link
Contributor

Pull in fix from scylladb/go-set@cc7b207 to prevent compile issues on 32 bit architectures:

$ GOOS=linux GOARCH=386 go build  ...
# github.com/scylladb/go-set/strset
../../.gvm/pkgsets/go1.18/global/pkg/mod/github.com/scylladb/[email protected]/strset/strset.go:248:13: cannot use math.MaxInt64 (untyped int constant 9223372036854775807) as int value in assignment (overflows)
../../.gvm/pkgsets/go1.18/global/pkg/mod/github.com/scylladb/[email protected]/strset/strset.go:255:16: math.MaxInt64 (untyped int constant 9223372036854775807) overflows int

$ go get -d github.com/scylladb/go-set@master
go: downloading github.com/scylladb/go-set v1.0.3-0.20200225121959-cc7b2070d91e
go: upgraded github.com/scylladb/go-set v1.0.2 => v1.0.3-0.20200225121959-cc7b2070d91e

$ GOOS=linux GOARCH=386 go build  ...
# success!

@wagoodman wagoodman added the bug Something isn't working label Mar 23, 2022
@wagoodman wagoodman requested a review from a team March 23, 2022 16:20
@wagoodman wagoodman self-assigned this Mar 23, 2022
@wagoodman wagoodman enabled auto-merge (squash) March 23, 2022 18:18
@github-actions
Copy link

Benchmark Test Results

Benchmark results from the latest changes vs base branch 
name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2              1.47ms ± 4%    1.44ms ± 1%    ~     (p=0.056 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            3.70ms ± 3%    3.61ms ± 3%    ~     (p=0.095 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2    1.19ms ± 0%    1.17ms ± 2%    ~     (p=0.151 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         784µs ± 0%     792µs ± 3%    ~     (p=0.690 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     926µs ± 1%     942µs ± 2%    ~     (p=0.056 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      825µs ± 2%     827µs ± 2%    ~     (p=0.690 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      16.1ms ± 1%    15.0ms ± 2%  -6.80%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.52ms ± 1%    1.42ms ± 2%  -6.54%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          2.60µs ± 1%    2.36µs ± 2%  -9.20%  (p=0.008 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2               182kB ± 0%     182kB ± 0%    ~     (p=1.000 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             894kB ± 0%     893kB ± 0%  -0.12%  (p=0.016 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     194kB ± 0%     194kB ± 0%  -0.14%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         138kB ± 0%     138kB ± 0%    ~     (p=1.000 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     173kB ± 0%     172kB ± 0%  -0.16%  (p=0.016 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      162kB ± 0%     161kB ± 0%  -0.12%  (p=0.032 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      3.18MB ± 0%    3.18MB ± 0%    ~     (p=0.222 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.23MB ± 0%    1.23MB ± 0%    ~     (p=1.000 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            608B ± 0%      608B ± 0%    ~     (all equal)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2               3.67k ± 0%     3.67k ± 0%    ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2             14.9k ± 0%     14.9k ± 0%    ~     (p=0.063 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     4.98k ± 0%     4.98k ± 0%    ~     (p=1.000 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         2.70k ± 0%     2.70k ± 0%    ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                     3.97k ± 0%     3.97k ± 0%    ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                      3.99k ± 0%     3.99k ± 0%    ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                       51.9k ± 0%     51.9k ± 0%    ~     (p=0.476 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      4.83k ± 0%     4.83k ± 0%    ~     (p=0.643 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            14.0 ± 0%      14.0 ± 0%    ~     (all equal)

@wagoodman wagoodman disabled auto-merge March 23, 2022 18:23
@wagoodman wagoodman changed the title Bump strset version to fix 386 builds bump strset version to fix 386 builds Mar 23, 2022
@wagoodman wagoodman merged commit cc2c0e5 into main Mar 23, 2022
@wagoodman wagoodman deleted the bump-strset branch March 23, 2022 18:34
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@wagoodman
bump strset version to fix 386 builds (anchore#911)
3a0a969
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonasagx jonasagx jonasagx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wagoodman wagoodman

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wagoodman @jonasagx