Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@pkuczynski
Copy link
Collaborator

@pkuczynski pkuczynski commented Feb 21, 2018

Upgraded packages:

    "browserslist": "^3.1.1",
    "caniuse-lite": "^1.0.30000810",

Allows to specify in browsers new dead option https://github.com/ai/browserslist/blob/master/CHANGELOG.md#30

Fixes #84

Upgraded packages:

```
    "browserslist": "^3.1.1",
    "caniuse-lite": "^1.0.30000810",
```

Allows to specify in `browsers` new `dead` option https://github.com/ai/browserslist/blob/master/CHANGELOG.md#30
@ghost
Copy link

ghost commented Feb 21, 2018

Duplicate of #84, but I'm all in favor of these changes :)

@pkuczynski
Copy link
Collaborator Author

Not really. #84 has older deps and bring in some other changes :) However, both would fix my issue :) Do you think anybody will merge them in? There is quite a few PR piled in the queue...

@ghost
Copy link

ghost commented Feb 22, 2018

Not really. #84 has older deps and bring in some other changes

There's a caret in front of the version numbers, so users will install the latest minor/patch version anyway. So it doesn't matter if the listed version in package.json is older.

Do you think anybody will merge them in? There is quite a few PR piled in the queue...

They're looking for a maintainer atm actually. So it might be a while, but I don't know if you would like a shot at maintaining this? I'm sure they'd be open to it.

@pkuczynski
Copy link
Collaborator Author

Sure. I already maintain some other open source projects, so one would not make a big difference ;) Who should I talk to about it?

@ghost
Copy link

ghost commented Feb 22, 2018

Great! @ai has credentials, he’s the one to talk to if I’m not mistaken

@ai
Copy link
Collaborator

ai commented Feb 22, 2018

@pkuczynski so you want to maintain this project and want a access to GitHub and npm?

@pkuczynski
Copy link
Collaborator Author

Sure. It's pretty useful I think. Especially for the project, I am working on currently. How can we organize this?

@ai
Copy link
Collaborator

ai commented Feb 22, 2018

@pkuczynski I need your npm login

@ai
Copy link
Collaborator

ai commented Feb 22, 2018

@ismamz I don’t have access to GitHub repo :(. Can you add him to admins?

@ghost
Copy link

ghost commented Feb 22, 2018

@ai Ah damn, neither do I. I removed myself from the group after ‘stepping down’ as a maintainer, so I no longer have any rights. I thought you still had them

@pkuczynski
Copy link
Collaborator Author

@ai my npm login is pkuczynski

@ai
Copy link
Collaborator

ai commented Feb 22, 2018

@ismay removing yourself before finding next maintainer is not the best way ;). At least we could have a big security issue which must be fixed fast.

I wrote to origin author @anandthakker

@pkuczynski
Copy link
Collaborator Author

Yeah, that's what I figured out looking at contributors

@ghost
Copy link

ghost commented Feb 22, 2018

@ai Yeah you’re right, I didn’t think of that at the time

@anandthakker
Copy link
Owner

@pkuczynski added you to the repo and NPM. 🙏 thanks for agreeing to step in!

@pkuczynski
Copy link
Collaborator Author

Looks good! Thanks. Let's see how it goes :)

@pkuczynski pkuczynski merged commit 3cdf569 into anandthakker:master Feb 25, 2018
@pkuczynski pkuczynski deleted the patch-1 branch February 25, 2018 09:59
@pkuczynski pkuczynski added this to the 4.1.0 milestone Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants