Remove outdated ldjson-stream #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @anandthakker are you interested in this PR? |
Contributor
|
you'd have better luck with @clshortfuse :) |
Collaborator
|
I've lost track of a couple things, but I'll put this on the milestone for sure. |
Contributor
Author
|
awesome, thanks :) |
Collaborator
|
Looks good. The only difference is ldjson-stream uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR removes
ldjson-stream, which hasn't been updated in 9 years and brings some very outdated dependencies (such asthrough20.6.5)I'm replacing it with no dependency since the feature itself can be done easily in modern Node