Performance: Cache missingSupport and refactor Detector
#182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missingSupport and refactor Detector
clshortfuse
reviewed
Mar 19, 2024
Collaborator
clshortfuse
left a comment
There was a problem hiding this comment.
Thanks for the PR. It all looks good. Just left some comments in case some improvements can be made.
Contributor
Author
|
hi @clshortfuse, just a friendly bump on this PR :) |
clshortfuse
approved these changes
Jun 21, 2024
WojtekMasiukiewicz
approved these changes
Aug 23, 2024
WojtekMasiukiewicz
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the performance of
doiusein two ways, making it run 3-10 times faster:BrowserSelection.missingSupport(), since compiling the list of missing features is an expensive operation. This improves performance when the postcss plugin is run over multiple CSS files, like when linting an entire codebase.Detectorto flatten and normalise all feature checks during initialization, rather than using expensiveObject.entriesoperations to parse the rules at every node in the syntax tree.Benchmarks (from master...RJWadley:doiuse:benchmark-2):
missingSupportDetectorOther benchmarks: