Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@rgetz
Copy link
Contributor

@rgetz rgetz commented Jan 9, 2019

This adds a two more distributions to the build matrix : raspbian jessie and raspbian stretch.

This should also provide a basic framework for those non-native travis-ci architectures in the future that we may want to support.

Signed-off-by: Robin Getz [email protected]

Copy link
Contributor

@mhennerich mhennerich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- compiler: "gcc"
dist: xenial
env:
- ARCH=arm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you change this to OS_TYPE=qemu_arm and define a handle_qemu_arm() function in ./CI/travis/before_install_linux and another one in ./CI/travis/make_linux

moving the code from ./CI/travis/setup_qemu_for_arm.sh to ./CI/travis/before_install_linux is a bit much; so handle_qemu_arm() could just call or include./CI/travis/setup_qemu_for_arm.sh`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for review - I can try this later tonight.

sudo chown ${USER} /tmp/qemu
cd ${QEMU_DIR}
wget https://download.qemu.org/qemu-3.1.0.tar.xz
tar xf qemu-3.1.0.tar.xz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curios: would the default QEMU work ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, there may be some good news here [no guarantees that it actually works though, but it would be worth taking a closer look] ;
you could use Travis-CI's integration with Debian Sid packages to get a new QEMU [3.1 or something]

QEMU in Sid seems to be 3.1 [now] : https://packages.debian.org/sid/qemu

What you typically would do, is:

addons:
  apt:
    sources:
    - debian-sid
    packages:
    - qemu

I "think" Travis-CI keeps a list of whitelisted packages; they don't seem to just allow anything from Sid. I don't remember exactly.

I did do this [Debian-Sid usage] a while back on some other project, and it's a mix of experiences ; some worked great, but if you mix-in other stuff [or APT sources] then using debian-sid can confuse other parts of the build.

Still [if possible] I would try it, mostly to reduce the build logic here, but especially to try to reduce the build-time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curios: would the default QEMU work ?

No - it's too old, and gives errors during make package. it doesn't support some ioctls which cmake uses.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still [if possible] I would try it, mostly to reduce the build logic here, but especially to try to reduce the build-time.

building qemu doesn't take the time (thats 2-3 min our of 20) - it's downloading the entire dist for ARM that takes the time...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QEMU in Sid seems to be 3.1 [now] : https://packages.debian.org/sid/qemu

We actually need qemu-user-static to run in the chroot; so it would be https://packages.debian.org/sid/qemu-user-static (which is still there).

@rgetz
Copy link
Contributor Author

rgetz commented May 5, 2019

I thought I answered all the questions — can this get merged? We did a release without ...

@mhennerich
Copy link
Contributor

I thought I answered all the questions — can this get merged? We did a release without ...

Yes this can get merged - in fact I don't know why this hasn't been already. I approved this PR 4 months ago. Please follow up if things don't move...

@mhennerich mhennerich merged commit 4e22517 into master May 6, 2019
@mhennerich mhennerich deleted the qemu_arm branch May 6, 2019 05:54
@mhennerich
Copy link
Contributor

Since this PR was only CI related and didn't change any library source files. I moved to the v0.18 release tag to include this. A new build is currently triggered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants