Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

benpsnyder
Copy link
Contributor

🎯 Overview

This PR introduces comprehensive Cursor IDE integration and development rules to enhance the developer experience across the entire Analog workspace. The changes establish consistent coding practices, AI-assisted development capabilities, and streamlined workflows for all contributors.

✨ Key Changes

🔧 Infrastructure Enhancements

  • Nx MCP Server Integration: Added .cursor/mcp.json for AI-assisted development with Nx tools
  • TUI Configuration: Enabled terminal UI features in nx.json for better developer experience
  • Global Development Rules: Established workspace-wide coding standards and best practices

📚 Package-Specific Documentation

  • 37 new rule files added across all packages and apps
  • Individual development guidelines for each of the 12 Analog packages
  • CI/CD best practices tailored to each package's specific needs
  • Architecture guidance for maintainable and scalable code

🏗️ Development Workflow Improvements

  • Consistent Nx usage patterns with tool-specific guidelines
  • Automated workflow guidance for common development tasks
  • Package-specific onboarding for new contributors
  • AI-assisted development with context-aware coding assistance

💢 Impact

  • +2,881 lines of development documentation and guidelines
  • 37 files added for comprehensive development support
  • 12 packages now have individual development rule sets
  • 5 apps equipped with specific CI/CD guidelines

🚀 Benefits for Maintainers

  1. Consistent Code Quality: Standardized development practices across all packages
  2. Faster Onboarding: Clear guidelines for new contributors
  3. Reduced Review Time: Established patterns and best practices
  4. Better Tooling: AI-assisted development with Nx integration
  5. Automated Workflows: Streamlined CI/CD processes

📁 Files Changed

Global Configuration

  • .cursor/mcp.json - Nx MCP server configuration
  • .cursor/rules/nx-rules.mdc - Nx workspace guidelines
  • .cursor/rules/repo-ci-cd.mdc - Global CI/CD practices
  • .cursor/settings.json - Cursor IDE settings
  • nx.json - TUI configuration added

Package-Specific Rules

Each package now includes:

  • .cursor/rules/ci-cd.mdc - CI/CD guidelines
  • .cursor/rules/development.mdc - Development best practices

Apps: analog-app, blog-app, docs-app, ng-app, trpc-app
Packages: astro-angular, content, content-plugin, create-analog, nx-plugin, platform, router, storybook-angular, trpc, vite-plugin-angular, vite-plugin-nitro, vitest-angular

🧪 Testing

  • All existing functionality remains unchanged
  • No runtime dependencies added
  • Configuration changes are additive and non-breaking
  • Development rules provide guidance without enforcing breaking changes

📝 Migration Notes

  • No migration required for existing code
  • New development rules are opt-in and provide guidance
  • CI/CD workflows remain compatible with existing processes
  • Nx MCP server integration is optional and can be disabled

@netlify
Copy link

netlify bot commented Aug 2, 2025

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 6a53072
🔍 Latest deploy log https://app.netlify.com/projects/analog-blog/deploys/68a0a5600adc5d0008d85a1f
😎 Deploy Preview https://deploy-preview-1819--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Aug 2, 2025

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 6a53072
🔍 Latest deploy log https://app.netlify.com/projects/analog-docs/deploys/68a0a56053723b00083fddb9
😎 Deploy Preview https://deploy-preview-1819--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Aug 2, 2025

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 6a53072
🔍 Latest deploy log https://app.netlify.com/projects/analog-app/deploys/68a0a56053723b00083fddbb
😎 Deploy Preview https://deploy-preview-1819--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@benpsnyder
Copy link
Contributor Author

benpsnyder commented Aug 2, 2025

@brandonroberts plan is to keep stacking rules per package so we can do some refactoring (no changes to functionality) to enhance test coverage, debuggability, and make it easy for new contributors to understand the pipeline of the tooling ... vite/nitro/h3 etc ...
Once stable in the beta branch we can then use this to make more aggressive changes in alpha

@netlify
Copy link

netlify bot commented Aug 2, 2025

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit 6a53072
🔍 Latest deploy log https://app.netlify.com/projects/analog-ng-app/deploys/68a0a5601349850008a9f17d
😎 Deploy Preview https://deploy-preview-1819--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@benpsnyder
Copy link
Contributor Author

@brandonroberts apps/**/.cursor has been removed

- Lint: `nx lint content-plugin`

## Build Details
- Uses esbuild executor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect.

Suggested change
- Uses esbuild executor
- Uses esbuild executor

- Part of release build process

## Build Details
- Uses esbuild executor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

## Build Details
- Uses esbuild executor
- Multiple entry points for different features
- Output format: CommonJS No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an ESM plugin

label: 'Version Compatibilty',
},
{
type: 'doc',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go into a different section for developers. This isn't necessarily for end users

},
"nxCloudAccessToken": "NDRkYzdkYmMtNDI3NS00MDI0LWFkMGQtMmI0Zjc2MTY2YzU0fHJlYWQtb25seQ==",
"defaultBase": "beta",
"tui": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert these

- Part of release build process

## Testing
- Unit tests with Jest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Unit tests with Jest
- Unit tests with Vitest

## Build Details
- TypeScript compilation with swc
- Generators and executors for Nx workspace
- Not tagged for release (published separately) No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package is published as part of the @analogjs/platform package.

Comment on lines +114 to +116
builder: {
viteConfigPath: 'path/to/vite.config.ts'
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

Suggested change
builder: {
viteConfigPath: 'path/to/vite.config.ts'
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants