feat(vite-plugin-angular): add support for tsconfig as getter function #1892
+62
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
working on fixing the tests now |
8bb27cc to
e428dde
Compare
Contributor
Author
|
@brandonroberts it's not as clean as I hoped for, but there's an issue I tried to avoid. The Nx plugin is generating the tsconfig during the So I needed to find a way to resolve the tsconfig twice, both in It's not pretty looking, but maybe you have a different idea on how to solve it in a cleaner way. |
brandonroberts
approved these changes
Oct 11, 2025
brandonroberts
pushed a commit
that referenced
this pull request
Oct 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Recently, I've made buildable libs available for vitest in Nx (to improve testing speed in large nx monorepos)
In order to be able to have the angular compiler work with the tsconfig generated by Nx (with the paths pointing to the
dist/folder), a more dynamic way to get the tsconfig path is needed in the angular-vite plugin.What is the new behavior?
My change is simple, it allows the user to either provide a string (like the current implementation) or to provide a getter function.
That way, during the angular compilation, once Nx already generated the "dist" tsconfig, we can make sure that generated tsconfig path is being passed to the
performCompilationfunction, and by that the angular compiler could use the already built libs paths (because the getter runs dynamically and not only when configuring the plugin)Does this PR introduce a breaking change?
Other information
[optional] What gif best describes this PR or how it makes you feel?