Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@brandonroberts
Copy link
Member

PR Checklist

Related to taiga-family/taiga-ui#9085

What is the new behavior?

When using @ng-web-apis or @taiga-ui packages, no errors are thrown when using SSR. Our dependency crawler plugin doesn't account for peer dependencies inside top-level packages, so some of the packages were not being transformed for Angular compilation.

Manually this was fixed by adding those orgs to the ssr.noExternal array in the vite.config.ts

    ssr: {
      noExternal: [
        '@analogjs/trpc',
        '@trpc/server',
        '@ng-web-apis/**', // <-- transform all `@ng-web-apis` sub-packages
        '@taiga-ui/**',  // <-- transform all `@taiga-ui` sub-packages
      ],
    },

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit 14de372
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/66ec1fbb9aab6900081142cf
😎 Deploy Preview https://deploy-preview-1357--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 14de372
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/66ec1fbb450b730008a52f75
😎 Deploy Preview https://deploy-preview-1357--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 14de372
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/66ec1fbb37d19a0008ea31d7
😎 Deploy Preview https://deploy-preview-1357--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 14de372
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/66ec1fbb4982170008200fa3
😎 Deploy Preview https://deploy-preview-1357--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts merged commit 7f7d192 into beta Sep 19, 2024
24 checks passed
@brandonroberts brandonroberts deleted the fix-taiga-ui-deps branch September 19, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant