feature: update app generators and templates to use TypeScript for Tailwind config #1387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for analog-ng-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
brandonroberts
approved these changes
Oct 6, 2024
|
@redfox-mx will you fix the merge conflict? |
|
Sure n.n |
f87e801 to
f72087f
Compare
|
Damn 😭 😭 I delete all my commits |
Ts support was added in v3.1.0, projects with tailwind ~3.0.0 cannot be correctly updated
45f12b2 to
19f0759
Compare
|
Hi @brandonroberts would you matter try to test pnpm install and pnpm-lock generation, please? |
|
I tested the PR locally and everything works |
|
Thanks! @allcontributors add @redfox-mx for code,infra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Closes #1297
What is the new behavior?
Now new tailwind projects are generated with typescript configuration file.
Generator for tailwind apps are updated to support typescript
Does this PR introduce a breaking change?
Other information
Project with tailwind ~3.0.0 not be setted correctly cause types definitions (and maybe ts support too) was added in version 3.1.0
[optional] What gif best describes this PR or how it makes you feel?