This repository was archived by the owner on Feb 13, 2024. It is now read-only.
rpc: use ByteSizeLong from protobuf #1480
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that CI doesn't like it. I guess it uses an older version of protobuf. |
7775f90 to
76fbe4d
Compare
ByteSize() is deperecated, and BiteSizeLong() returns a size_t already, which is what we use. This way, we also avoid potential overflows when casting to int back and from.
76fbe4d to
f4c3884
Compare
|
CI is fixed now. I believe this is ready for merging |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
still ready |
|
@morphis can this be reviewed? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
still ready
…On Sat, Apr 16 2022 at 16:17:46 -0700, stale[bot] ***@***.***> wrote:
This issue has been automatically marked as stale because it has not
had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ByteSize() is deperecated, and BiteSizeLong() returns a size_t already,
which is what we use. This way, we also avoid potential overflows when
casting to int back and from.