This repository was archived by the owner on Feb 13, 2024. It is now read-only.
Optionally use installed sdbus-cpp library #1733
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alpine is using a similar patch: https://gitlab.alpinelinux.org/alpine/aports/-/blob/master/community/anbox/no-bundled-sdbus.patch |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
What is this missing? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Still sounds useful... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a compile-once solution for the external project
sdbus-cppused for the docker container build toolchain.The installed library is used instead of building the in-tree module when it can be found with cmake
find_package.A fallback was implemented to avoid build errors in case the library is not installed on the host.
This is a small study to reduce build times by providing precompiled resources before Anbox is built.
The performance improvement is for niche use cases where the entire project is fully rebuild multiple times.
By introducing other concepts, the overall build time is reduced anyways. For example docker BuildKit, which reduces the buld time for the
anbox-buildimage.When accepted this will be a reference implementation with the other external modules following in the same style.
@morphis In
src/CMakeLists.txtthe include path forsdbus-cppis hardcoded. I would like to use something likesdbus-c++_INLCUDE_DIRS, but the variable was empty. Do you know a work-around?