Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ltfish
Copy link
Member

@ltfish ltfish commented Oct 12, 2025

Also:

  • Fix a bogus warning about multiple out-of-region successors in switch-case structuring.

  • Support swapped condition operands when parsing ranges out of switch-case condition expressions.

  • Eliminate unnecessary cmp_bound extraction in Phoenix._match_acyclic_switch_cases_address_loaded_from_memory.

Also:

- Fix a bogus warning about multiple out-of-region successors in
switch-case structuring.

- Support swapped condition operands when parsing ranges out of
switch-case condition expressions.

- Eliminate unnecessary cmp_bound extraction in
Phoenix._match_acyclic_switch_cases_address_loaded_from_memory.
@ltfish ltfish self-assigned this Oct 12, 2025
@ltfish ltfish added bug Something is broken refactor Something needs to be reorganized labels Oct 12, 2025
@codecov
Copy link

codecov bot commented Oct 12, 2025

Codecov Report

❌ Patch coverage is 84.42623% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.05%. Comparing base (d74d3ef) to head (102b087).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
angr/analyses/decompiler/utils.py 52.17% 7 Missing and 4 partials ⚠️
angr/analyses/decompiler/structuring/phoenix.py 89.74% 3 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5719      +/-   ##
==========================================
- Coverage   73.05%   73.05%   -0.01%     
==========================================
  Files        1205     1205              
  Lines      125430   125541     +111     
  Branches    22078    22105      +27     
==========================================
+ Hits        91631    91708      +77     
- Misses      28221    28243      +22     
- Partials     5578     5590      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@angr-bot
Copy link
Member

Corpus decompilation diffs can be found at angr/dec-snapshots@master...angr/angr_5719

@ltfish ltfish merged commit 6d140d8 into master Oct 12, 2025
37 of 38 checks passed
@ltfish ltfish deleted the fix/phoenix_incomplete_switch_case_node_missing_successor branch October 12, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something is broken refactor Something needs to be reorganized

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants