FlirtMatcher: Tail bytes follow CRC region #5785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5785 +/- ##
==========================================
+ Coverage 72.89% 72.97% +0.08%
==========================================
Files 1218 1218
Lines 128775 128772 -3
Branches 22978 22978
==========================================
+ Hits 93868 93975 +107
+ Misses 28947 28862 -85
+ Partials 5960 5935 -25 ☔ View full report in Codecov by Sentry. |
4d23d62 to
92345c1
Compare
Tail bytes follow CRC region.
__printf signature depends on vfprintf reference, but vfprintf is absent in the test signature file so the __printf reference check fails. This test passed previously because nampa does not do reference checks.
92345c1 to
a37a5ed
Compare
This was referenced Nov 12, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
@slow_testsshould always be run #5775