feat(forms): Allow returning plain values from validators #64339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4043e76 to
4219a37
Compare
c54f6fd to
9820508
Compare
leonsenft
reviewed
Oct 15, 2025
| export type FieldValidationResult<E extends ValidationError = ValidationError> = | ||
| | ValidationSuccess | ||
| | OneOrMany<WithoutField<E>>; | ||
| | OneOrMany<E>; |
Contributor
There was a problem hiding this comment.
With this change, this type becomes equivalent to ValidationResult so there isn't a need for both.
Contributor
There was a problem hiding this comment.
In fact, it also makes TreeValidationResult irrelevant since that optionally supports fields, which the error type now does as well.
Contributor
Author
There was a problem hiding this comment.
I undid this change, now they are different things
Contributor
There was a problem hiding this comment.
as @leonsenft mentioned, can we just remove these now?
Contributor
Author
There was a problem hiding this comment.
I droppped FieldValidationResult, TreeValidationResult is different though?
mmalerba
reviewed
Oct 21, 2025
676a5d6 to
c9394d3
Compare
9dcbeee to
0d71d4c
Compare
mmalerba
reviewed
Oct 23, 2025
| export type FieldValidationResult<E extends ValidationError = ValidationError> = | ||
| | ValidationSuccess | ||
| | OneOrMany<WithoutField<E>>; | ||
| | OneOrMany<E>; |
Contributor
There was a problem hiding this comment.
as @leonsenft mentioned, can we just remove these now?
packages/forms/signals/test/node/api/validators/validation_errors.spec.ts
Show resolved
Hide resolved
edbc533 to
a3be21f
Compare
leonsenft
reviewed
Oct 24, 2025
packages/forms/signals/test/node/api/validators/required.spec.ts
Outdated
Show resolved
Hide resolved
packages/forms/signals/test/node/api/validators/validation_errors.spec.ts
Outdated
Show resolved
Hide resolved
packages/forms/signals/test/node/api/validators/validation_errors.spec.ts
Outdated
Show resolved
Hide resolved
b2f27cb to
3976ab3
Compare
leonsenft
approved these changes
Oct 27, 2025
packages/forms/signals/test/node/api/validators/validation_errors.spec.ts
Outdated
Show resolved
Hide resolved
packages/forms/signals/test/node/api/validators/validation_errors.spec.ts
Outdated
Show resolved
Hide resolved
mmalerba
approved these changes
Oct 28, 2025
This makes the API nicer to use
This makes the API nicer to use
This makes the API nicer to use
3976ab3 to
a1d99ba
Compare
This makes the API nicer to use
a1d99ba to
7c62043
Compare
mmalerba
approved these changes
Oct 28, 2025
Contributor
mmalerba
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the API nicer