fix: remove 100ms delay on first and subsequent read calls #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, there is an unnecessary wait with `recv_timeout()` on reader thread which causes reading from pipe to have an inherent 100ms wait time. Similarly, cache thread also has this issue, where read() calls are served throttled with a 100ms delay
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
+ Coverage 77.57% 78.63% +1.05%
==========================================
Files 7 7
Lines 1231 1231
==========================================
+ Hits 955 968 +13
+ Misses 276 263 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thanks a lot for your contribution @SilverMira! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is an unnecessary wait with
recv_timeout()on reader thread and cache thread.On reader thread, it causes reading from pipe to have an inherent 100ms wait time between each chunk read.
Similarly, cache thread also has this issue, where read() calls are served throttled with a 100ms delay.
This PR replaces
recv_timeoutwithtry_recvso all read() calls will return as soon as possible.Fixes #75