-
Notifications
You must be signed in to change notification settings - Fork 10
Fix unsupported browser issue #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
the directory structure under dist changed after updating the dependencies
|
@alexandru0-dev I tested it out and it works. Please feel free to merge. Thank you. |
|
@andirsun this is ready to merge |
|
somehow this doesn't work for me... checked out the latest slacky from here, applied your patch (hardcoded change of user agent) and I still get the "browser not supported" message. |
Idk if I can help but what distro are you using? |
|
Somehow I doubt that the distro has anything to do with it, but to answer your question: I am on asahi fedora linux (F42) on an apple M2 macbook air. As far as dependencies, here it is: 〉npm info
[email protected] | MIT | deps: 3 | versions: 5
A minimalistic slack bot framework.
https://github.com/michaeljacobdavis/slacky#readme
dist
.tarball: https://registry.npmjs.org/slacky/-/slacky-2.1.0.tgz
.shasum: 34dd94dfdd30095314f3b1a996d0129b631d9cdf
.integrity: sha512-tUeyr0SZ18XFLgJNJggT6XnNbieXYcogGFuOdVnzjm49PjLHKCp5iHIWQuBi0EhzErdC9mpJhqn7KLkaU3ImLw==
dependencies:
@slack/client: ^2.3.0 items: ^2.0.0 wrap-fn: ^0.1.5
maintainers:
- michaeljacobdavis <[email protected]>
dist-tags:
latest: 2.1.0
published over a year ago by michaeljacobdavis <[email protected]>I cloned the latest Slacky: 〉git log
commit 82e96b719eff0f702ad275d8bc17aea2487ca122 (HEAD -> main, origin/main, origin/HEAD)
Author: Anderson Laverde <[email protected]>
Date: Mon May 12 06:50:20 2025 +0100
Create LICENSE (#34)
[...]applied your patch (actually just edited src/main.ts and replace the line with the user agent), |
You should also update the main entry inside the package.json Btw it should be now on main |
|
Just cloned the latest main, it works. Thanks! |
* fix incorrect main entry point the directory structure under dist changed after updating the dependencies * update userAgent to a newer one
User agent provided by: https://www.useragents.me/
I don't really like the fact that the user-agent is hardcoded but it works
maybe in the future to integrate it directly basing from https://github.com/DavideViolante/useragents-me-api/?
(it's unofficial and basically doing web scraping, you could copy paste it so removing an extra dependency)
Closes #30