Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add golangci-lint #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andrewkroh merged 18 commits into from
Mar 16, 2022
Merged

Add golangci-lint #48

andrewkroh merged 18 commits into from
Mar 16, 2022

Conversation

@andrewkroh
Copy link
Owner

@andrewkroh andrewkroh commented Mar 16, 2022 •
edited
Loading

Add golangci-lint to check changes during pull requests. And fix all of the existing issues detected.

andrewkroh added 18 commits March 16, 2022 11:37
@andrewkroh
gofumpt
c46ff40 
[git-generate]

gofumpt -w -extra $(find . -name '*.go')
@andrewkroh
goimports
cf6d13d 
[git-generate]

goimports -w -l -local github.com/andrewkroh/gvm $(find . -name '*.go')
@andrewkroh
misspell
82ef834
@andrewkroh
Remove usage of archived github.com/pkg/errors
d09939f
@andrewkroh
prealloc
5b072c4
@andrewkroh
unused-receiver
4d7b315
@andrewkroh
error-strings
97cd949
@andrewkroh
defer: prefer not to defer inside loops
dde521f
@andrewkroh
unused-parameter
fd6ed8d
@andrewkroh
Use errors.Is to check for a specific error
c0a8c73
@andrewkroh
ifshort
13f4039 
variable 'tryBinary' is only used in the if-statement (gvm.go:264:2); consider using short syntax
@andrewkroh
ST1003: func gitLastCommitTs should be gitLastCommitTS
9709bf1
@andrewkroh
ST1003: func writeJsonFile should be writeJSONFile
394cc79
@andrewkroh
ST1003: func readJsonFile should be readJSONFile
28377df
@andrewkroh
unused-receiver
ea70ca6
@andrewkroh
unused-parameter
2104532
@andrewkroh
ST1008: error should be returned as the last argument
cd153e8
@andrewkroh
Add golangci-lint
ffbf433
@andrewkroh
Copy link
Owner Author

andrewkroh commented Mar 16, 2022

Waiting on the GH actions incident to clear up before I can test this. https://www.githubstatus.com/incidents/fpk08rxnqjz2

@andrewkroh andrewkroh changed the title Golangci lint Add golangci-lint Mar 16, 2022
@andrewkroh andrewkroh merged commit 613c144 into main Mar 16, 2022
@andrewkroh andrewkroh deleted the golangci-lint branch March 16, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewkroh