Commits

Branch selector

 master

User selector

janakdr

Datepicker

All time

Commit History

Commits on Apr 20, 2018

• Add BazelCrashUtils to make it easier to crash the JVM when uncaught exceptions are detected in async worker threads.

  Show description for 5bfe343
  

  janakdr

  authored and

  Copybara-Service

  committed
  5bfe343

  Copy full SHA for 5bfe343

Commits on Apr 18, 2018

• Automated rollback of commit 559ffb7dd6578c961e775ba4901917ab8bffcb9d.

  Show description for 5a93937
  

  janakdr

  authored and

  Copybara-Service

  committed
  5a93937

  Copy full SHA for 5a93937

Commits on Apr 16, 2018

• Add ValueConstants helper to handle the increasingly complex logic for value-equality-tested constants. Main hurdle is efficiently testing to see if a Collection is a value constant without trying …

  Show description for 559ffb7
  

  janakdr

  authored and

  Copybara-Service

  committed
  559ffb7

  Copy full SHA for 559ffb7

Commits on Apr 13, 2018

• Use canonical EMPTY_ARGS JavaCompilationArgs object if all nested set builders are empty, and @AutoCodec EMPTY_ARGS.

  Show description for 6020951
  

  janakdr

  authored and

  Copybara-Service

  committed
  6020951

  Copy full SHA for 6020951

Commits on Apr 12, 2018

• Prefix-compress strings during memoizing serialization.

  Show description for ac9ba40
  

  janakdr

  authored and

  Copybara-Service

  committed
  ac9ba40

  Copy full SHA for ac9ba40

Commits on Apr 11, 2018

• Remove all callers of ArtifactRoot.asSourcePath from production code besides the ones in SkyframeExecutor, called once for each Root in the package path list. This ensures there is a single canonic…

  Show description for 7f15b68
  

  janakdr

  authored and

  Copybara-Service

  committed
  7f15b68

  Copy full SHA for 7f15b68

Commits on Apr 10, 2018

• Add value constants to ObjectCodecRegistry. Value constants are to be used when there may not be a canonical instance of the object we want (or the canonical instance isn't available at registry co…

  Show description for 2b533ab
  

  janakdr

  authored and

  Copybara-Service

  committed
  2b533ab

  Copy full SHA for 2b533ab

• Make some objects frequently encountered during serialization into constants. A lot of care is needed here because we're using reference equality. I plan to add value-equality constants in a follow…

  Show description for a124bbf
  

  janakdr

  authored and

  Copybara-Service

  committed
  a124bbf

  Copy full SHA for a124bbf

• Update documentation of RuleConfiguredTargetFactory to reflect recent refactorings of Target and BuildConfiguration out of ConfiguredTarget. Also use fully qualified imports as per style guide, sin…

  Show description for 4245af9
  

  janakdr

  authored and

  Copybara-Service

  committed
  4245af9

  Copy full SHA for 4245af9

Commits on Apr 9, 2018

• Serialize Artifacts by their root-relative path rather than their exec path. The exec path contains redundant information when considered with the ArtifactRoot, so, since the ArtifactRoot is memoiz…

  Show description for 825946b
  

  janakdr

  authored and

  Copybara-Service

  committed
  825946b

  Copy full SHA for 825946b

Commits on Apr 5, 2018

• Make DynamicCodec always memoize. Since it replaces Java serialization, which memoizes, we should too.

  Show description for fdee70e
  

  janakdr

  authored and

  Copybara-Service

  committed
  fdee70e

  Copy full SHA for fdee70e

• Use @AutoCodec for NestedSet serialization.

  Show description for 2047796
  

  janakdr

  authored and

  Copybara-Service

  committed
  2047796

  Copy full SHA for 2047796

• Transform StackOverflowError thrown in ArrayCodec into SerializationException. This can happen with deep nested sets.

  Show description for 58fe737
  

  janakdr

  authored and

  Copybara-Service

  committed
  58fe737

  Copy full SHA for 58fe737

• Refactor CcToolchainFeatures$Variables to not create a map in the case of a singleton.

  Show description for f04efab
  

  janakdr

  authored and

  Copybara-Service

  committed
  f04efab

  Copy full SHA for f04efab

Commits on Apr 4, 2018

• Add codec for Object[]. This may be useful for NestedSetCodec, pushing up so that my uncommitted change chain is a little more manageable.

  Show description for b7d65cd
  

  janakdr

  authored and

  Copybara-Service

  committed
  b7d65cd

  Copy full SHA for b7d65cd

• Save the lookup and write of the codec index when the object is memoized, as well as the NEW_VALUE/BACKREF enum write. Probably doesn't actually take much space/time, but free optimization.

  Show description for b4897fc
  

  janakdr

  authored and

  Copybara-Service

  committed
  b4897fc

  Copy full SHA for b4897fc

• Add ObjectCodec for AtomicReference.

  Show description for eb0671b
  

  janakdr

  authored and

  Copybara-Service

  committed
  eb0671b

  Copy full SHA for eb0671b

Commits on Apr 3, 2018

• Don't do serialization of empty/singleton nested sets into a child CodedOutputStream. It creates immense amounts of garbage and we don't ever use the result: it's only used for Object[] children an…

  Show description for 9416409
  

  janakdr

  authored and

  Copybara-Service

  committed
  9416409

  Copy full SHA for 9416409

• Disable nested set sharing across multiple nested set deserialization sessions. This is incorrect in the presence of memoization: a single element may be serialized as just a pair of integers (type…

  Show description for 7e8110b
  

  janakdr

  authored and

  Copybara-Service

  committed
  7e8110b

  Copy full SHA for 7e8110b

• Don't hold on to full byte array when deserializing protocol buffers.

  Show description for 17e56a4
  

  janakdr

  authored and

  Copybara-Service

  committed
  17e56a4

  Copy full SHA for 17e56a4

Commits on Apr 2, 2018

• Change profiling to only accept strings for its "description" argument. Profiling can hold onto objects for the duration of the build, and some of those objects may be temporary that should not be …

  Show description for 52859b4
  

  janakdr

  authored and

  Copybara-Service

  committed
  52859b4

  Copy full SHA for 52859b4

Commits on Mar 30, 2018

• Make RuleClass serializable and remove Environment from it, since it was only being used for the transitive hash code and transitive label of its globals, which can be passed in explicitly.

  Show description for d3fe5e7
  

  janakdr

  authored and

  Copybara-Service

  committed
  d3fe5e7

  Copy full SHA for d3fe5e7

Commits on Mar 28, 2018

• Allow ConfiguredTargetFunction to release its CPU-bound semaphore during dep requests if SkyframeExecutor has reason to believe that those requests may not be CPU-bound.

  Show description for 500e17b
  

  janakdr

  authored and

  Copybara-Service

  committed
  500e17b

  Copy full SHA for 500e17b

• Add codecs needed to fully serialize Attributes.

  Show description for 84efb09
  

  janakdr

  authored and

  Copybara-Service

  committed
  84efb09

  Copy full SHA for 84efb09

• Remove BuildConfiguration from ConfiguredTarget.

  Show description for 9c4fa4a
  

  janakdr

  authored and

  Copybara-Service

  committed
  9c4fa4a

  Copy full SHA for 9c4fa4a

• Put configuration checksum into BuildOptions$OptionsDiffForReconstruction and make it available to ConfiguredTarget. Also give BuildConfigurationValue.Key the same toString() that BuildConfiguratio…

  Show description for 56d7852
  

  janakdr

  authored and

  Copybara-Service

  committed
  56d7852

  Copy full SHA for 56d7852

• Remove last few test uses of ConfiguredTarget#getConfiguration. Only uses are now internal, and the one that https://github.com/bazelbuild/bazel/commit/d350a897f6182d637ea819c41cd292a50c2db53d just…

  Show description for 73088a8
  

  janakdr

  authored and

  Copybara-Service

  committed
  73088a8

  Copy full SHA for 73088a8

Commits on Mar 27, 2018

• Replace nearly all test uses of ConfiguredTarget#getConfiguration with utility method getConfiguration(ConfiguredTarget). Done using IntelliJ structural replace, with

  Show description for a579d65
  

  janakdr

  authored and

  Copybara-Service

  committed
  a579d65

  Copy full SHA for a579d65

• Get rid of all remaining non-test non-internal uses of ConfiguredTarget#getConfiguration(). Add convenience methods in four Java test classes for use by refactoring tools to do this#getConfiguratio…

  Show description for 7292497
  

  janakdr

  authored and

  Copybara-Service

  committed
  7292497

  Copy full SHA for 7292497

• Remove ConfiguredTargetKey#of(ConfiguredTarget), since it calls ConfiguredTarget#getConfiguration.

  Show description for cc3890d
  

  janakdr

  authored and

  Copybara-Service

  committed
  cc3890d

  Copy full SHA for cc3890d

• Remove some more #getConfiguration calls (and some transitive ones through ConfiguredTargetKey#of(ConfiguredTarget)).

  Show description for 5720363
  

  janakdr

  authored and

  Copybara-Service

  committed
  5720363

  Copy full SHA for 5720363

• Thread configuration map through TestFilteringCompleteEvent. This isn't the most elegant solution, but I don't have a better idea.

  Show description for c9dcf83
  

  janakdr

  authored and

  Copybara-Service

  committed
  c9dcf83

  Copy full SHA for c9dcf83

• Get rid of ConfiguredTarget#getConfiguration() call in ConfiguredTargetFunction. The dep always has the right configuration, even in the case of an AliasConfiguredTarget.

  Show description for 4056249
  

  janakdr

  authored and

  Copybara-Service

  committed
  4056249

  Copy full SHA for 4056249

• Get rid of a few more #getConfiguration() calls. We're now passing a ConfiguredTargetAndData into TargetCompleteEvent, which seems reasonable.

  Show description for 60554e4
  

  janakdr

  authored and

  Copybara-Service

  committed
  60554e4

  Copy full SHA for 60554e4

Commits on Mar 26, 2018

• Don't assert that configurations are actually equal in ConfiguredTargetAndData debugging check.

  Show description for 88929e5
  

  janakdr

  authored and

  Copybara-Service

  committed
  88929e5

  Copy full SHA for 88929e5

Pagination

Previous

Next