Thanks to visit codestin.com
Credit goes to github.com

Skip to content

address feedback from MAD review and improve UX #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2025
Merged

address feedback from MAD review and improve UX #17

merged 2 commits into from
Oct 7, 2025

Conversation

@cka-dev
Copy link
Contributor

@cka-dev cka-dev commented Oct 6, 2025

Bug: 449768224
Change-Id: I48d374f3b513e19ad80f17a47f0ae5d1ca39bd21

@cka-dev
address feedback from MAD review and improve UX
687580e 
Bug: 449768224
Change-Id: I48d374f3b513e19ad80f17a47f0ae5d1ca39bd21
@cka-dev cka-dev requested a review from romanofranz as a code owner October 6, 2025 22:36
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Oct 6, 2025

Summary of Changes

Hello @cka-dev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on modernizing the Cahier application by updating its core dependencies, significantly enhancing the user interface and experience, and refining the underlying data management. The changes introduce adaptive layouts for better multi-device support, streamline note editing and drawing functionalities, and improve the robustness of data persistence with new database migrations. The overall goal is to create a more responsive, maintainable, and user-friendly application.

Highlights

  • Dependency Updates: Numerous dependencies including Android Gradle Plugin, Kotlin, Compose BOM, Hilt, Room, and Lifecycle libraries have been updated to their latest versions, ensuring the project uses modern and stable components.
  • Adaptive UI and UX Enhancements: The application now leverages Material 3's ListDetailPaneScaffold for improved adaptive layouts across various screen sizes. UI components for both text and drawing canvases have been refactored into smaller, more manageable composables, enhancing maintainability and user experience. New icons and tooltips have been introduced for better visual feedback.
  • Data Model and Persistence Improvements: The Note data model has been extended to include a clientBrushFamilyId for persisting selected drawing brushes. Database version has been incremented from 5 to 8, with a new migration (MIGRATION_7_8) implemented to handle changes in NoteType enum values (from uppercase to PascalCase). The StrokeEntity file has been removed, indicating a streamlined approach to stroke storage.
  • ViewModel Refinements: ViewModel logic has been updated to align with UI changes, including handling of new brush family IDs, improved image processing for drag-and-drop, and a new event channel for opening notes in new windows. Lifecycle-aware state collection (collectAsStateWithLifecycle()) is now widely adopted.
  • Modularization of Drawing Toolbox: The drawing canvas toolbox has been modularized into dedicated composables (DrawingToolbox, HorizontalToolbox, VerticalToolbox), allowing for responsive layout adjustments based on screen orientation or window size.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 6, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces significant improvements across the application, focusing on UX enhancements, code refactoring, and addressing feedback from a Modern Android Development (MAD) review. Key changes include adopting collectAsStateWithLifecycle, enabling edge-to-edge display, refactoring large composables into smaller, more manageable ones, and improving adaptive layouts for different screen sizes. The data layer has also been updated with a database migration to preserve user data and support for custom brushes. Overall, this is a high-quality update that modernizes the codebase and enhances the user experience. I've included a few suggestions for further refinement.

@cka-dev
address Gemini Code Assist comments
ecb58a2 
 Bug: 449768224

Change-Id: I051d424afce5a233944e33a787c0fe27bd6edcca
@romanofranz
Copy link
Contributor

romanofranz commented Oct 7, 2025

Next time let's try to split changes like this in multiple PRs. LGTM

@romanofranz romanofranz merged commit 317e5ea into main Oct 7, 2025
2 checks passed
@cka-dev cka-dev mentioned this pull request Oct 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romanofranz romanofranz romanofranz approved these changes

@miguelmontemayor miguelmontemayor Awaiting requested review from miguelmontemayor

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cka-dev @romanofranz