fix various UI bugs #18
Conversation
Bug: 449768224 Change-Id: I783bb1c67a6c05656178e6e3bdee2379065345a0
Summary of ChangesHello @cka-dev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on resolving various UI-related issues to improve the application's stability and user experience. The changes include updating a dependency import for better compatibility, implementing a mechanism to ensure text input fields accurately reflect underlying data changes, and refining the visual design of a key action button within the drawing interface. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to fix UI bugs. The change to use hiltViewModel from the correct lifecycle package is good. The update in DrawingToolbox.kt to use an IconButton for the 'Clear' action improves UI consistency. However, the new LaunchedEffect in CahierCanvasScreen.kt, while fixing the issue of note content not loading, introduces a critical data loss bug. My review includes a suggestion to fix this by changing the key of the LaunchedEffect to prevent overwriting user input during edits.
| mutableStateOf(TextFieldValue(uiState.note.text ?: "")) | ||
| } | ||
|
|
||
| LaunchedEffect(uiState.note) { |
There was a problem hiding this comment.
Using uiState.note as the key for LaunchedEffect can lead to data loss. Since note is a data class, any change to its properties (like isFavorite) will create a new object and trigger this effect. If the user is editing the title or body while another property changes (e.g., through a background sync or another UI action), their input could be overwritten by the state from uiState.note, which might be stale.
To prevent this, the effect should only run when the note itself changes, not on every property update. Using uiState.note.id as the key will ensure this effect runs only when a new note is loaded (when its ID changes), preventing accidental data loss during editing.
| LaunchedEffect(uiState.note) { | |
| LaunchedEffect(uiState.note.id) { |
Bug: 449768224 Change-Id: I0de13c14513537f15f735eb87c81bd8ce2955c39
Bug: 449768224
Change-Id: I783bb1c67a6c05656178e6e3bdee2379065345a0