migrate Ink API to beta01 and udpate custom brushes #24
Conversation
Bug: 452728815, 45088030, 455513544 Change-Id: I98d6fc54a0315f91e7892526bdaa5019cc008f8f
Summary of ChangesHello @cka-dev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on migrating the application's Ink API dependency to its Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully migrates the Ink API to beta01 and updates the brush handling logic. The API changes from the Ink library update, such as replacing StockBrushes.xxxLatest with StockBrushes.xxx(), have been applied correctly across the codebase. I have one suggestion regarding the new isBrushSelectedInSession flag to ensure consistent behavior for the user when modifying brush properties.
| if (!isBrushSelectedInSession) { | ||
| val customBrush = customBrushes.value.find { | ||
| it.brushFamily.clientBrushFamilyId == id | ||
| } | ||
| customBrush?.let { | ||
| _selectedBrush.value = | ||
| _selectedBrush.value.copy(family = it.brushFamily) | ||
| } | ||
| } |
There was a problem hiding this comment.
The introduction of isBrushSelectedInSession is a good improvement to prevent the selected brush from being reset. However, this flag is only set in changeBrush() and changeBrushAndSize(). For more consistent and predictable behavior, you should consider also setting isBrushSelectedInSession = true within changeBrushColor() and changeBrushSize().
Currently, if a user only changes the brush color or size (without changing the brush family), isBrushSelectedInSession remains false. This could lead to their color/size adjustments being unexpectedly overridden if the note data reloads, as the brush family would be reset to the one stored in the note. Treating any user modification to the brush as a 'selection' for the session would prevent this confusion.
Bug: 452728815, 45088030, 455513544 Change-Id: I5e4ffdaa27db3f122d1046f90819006c17e037ca
Bug: 452728815, 45088030, 455513544
Change-Id: I98d6fc54a0315f91e7892526bdaa5019cc008f8f