Hello @chikoski, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request addresses keyboard shortcut issues in the application. It modifies the way keyboard events are handled, ensuring actions are triggered on key press rather than key release. Additionally, it enables users to send messages using the Enter key in the chat screen without requiring the Shift key.

Highlights

• Keyboard Event Handling: The pull request modifies the isKeyPressed function to trigger actions on KeyDown events instead of KeyUp events.
• Send Message with Enter Key: The pull request enables sending messages in the chat screen by pressing the Enter key, removing the previous requirement of pressing Shift + Enter.

Changelog

• app/src/main/java/com/google/android/samples/socialite/MainActivity.kt
  • Modified the keyboard shortcut for sending messages to not require the Shift key.
• app/src/main/java/com/google/android/samples/socialite/ui/chat/ChatScreen.kt
  • Removed unused imports related to key event types.
  • Modified the scrollWithKeyboards modifier to handle scrolling events on key press instead of key release.
  • Modified the InputBar composable to allow sending messages with just the Enter key.
• app/src/main/java/com/google/android/samples/socialite/ui/chat/component/KeyEvent.kt
  • Modified the isKeyPressed function to check for KeyEventType.KeyDown by default.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

A key is pressed,
The message swiftly takes flight,
Chat flows with ease.

Code Review

The pull request addresses keyboard shortcut issues, enhancing the user experience by handling shortcuts only when a key is pressed and enabling message sending with the Enter key on the chat screen. The changes look good overall, but there are a few points that could be improved.

Summary of Findings

• KeyEventType Removal: The removal of KeyEventType check might lead to unintended behavior if KeyUp and KeyDown events are not handled correctly. It's crucial to ensure that the logic still works as expected without explicitly checking the event type.
• Redundant shouldShiftBePressed Parameter: In InputBar, the shouldShiftBePressed parameter was removed from the isKeyPressed function call. This might affect the expected behavior when using Shift + Enter.
• Keyboard Shortcut for Sending Messages: The change in MainActivity.kt removes the META_SHIFT_ON modifier for the send message shortcut. This means the user no longer needs to press Shift + Enter to send a message using the keyboard shortcut, which aligns with the pull request description.

Merge Readiness

The pull request addresses the keyboard shortcut issues as described. However, the removal of KeyEventType check and the change in shouldShiftBePressed parameter should be carefully reviewed to ensure no regressions are introduced. I am unable to directly approve the pull request, and other reviewers should review and approve this code before merging. I would recommend addressing the medium severity issue before merging.