Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jul 8, 2025. It is now read-only.

Conversation

@zackarhino
Copy link

Changed the name of the contribution file from CONTRIB.md to CONTRIBUTING.md. Also added a link to the file in README.md.

Relates to #212

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@zackarhino
Copy link
Author

I added the git email to my google account

@googlebot
Copy link

CLAs look good, thanks!

@zackarhino
Copy link
Author

I set the link in README.md to go to ../CONTRIBUTING.md rather than the current ../CONTRIB.md. I'm not sure if the link will change if the file name changes, but if not, can somebody update it for consistency?

Also, if this pull request goes through, can you please close #184 , #185 , and #213 ?

README.md Outdated

Patches are encouraged, and may be submitted by forking this project and
submitting a pull request through GitHub. Please see CONTRIBUTING.md for more details.
submitting a pull request through GitHub. Please see [CONTRIBUTING.md](https://github.com/googlesamples/android-UniversalMusicPlayer/blob/master/CONTRIBUTING.md) for more details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind changing this to just "CONTRIBUTING.md" so the link will be relative? Thank you!

@nic0lette nic0lette merged commit 0ae9add into android:master Jun 26, 2018
@nic0lette
Copy link
Contributor

Thank you for your contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants