Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Hello Android XR Updates #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 26, 2025
Merged

Hello Android XR Updates #19

merged 2 commits into from
Oct 26, 2025

Conversation

@amyZepp
Copy link
Contributor

@amyZepp amyZepp commented Oct 24, 2025

Author: azeppenfeld [email protected]
Date: Fri Oct 24 15:21:29 2025 -0700

Updating for best practices

Author: azeppenfeld [email protected]
Date: Thu Oct 16 18:48:28 2025 -0700

Cleaning up viewmodel

Author: azeppenfeld [email protected]
Date: Mon Oct 13 14:02:50 2025 -0700

Added ability to change material colors and other properties

Author: azeppenfeld [email protected]
Date: Thu Oct 2 18:30:49 2025 -0700

Added ability to rotate, scale, and change the offset of a GLTF

Author: azeppenfeld [email protected]
Date: Wed Oct 1 13:26:55 2025 -0700

upgrading to alpha07 and a few other minor changes

Adding bugdroid controller

Author: azeppenfeld [email protected]
Date: Fri Sep 19 13:23:11 2025 -0700

Added start/stop animation when BugDroid is shown

@amyZepp
Squashed commit of the following:
78bf472 
Author: azeppenfeld <[email protected]>
Date:   Fri Oct 24 15:21:29 2025 -0700

    Updating for best practices

Author: azeppenfeld <[email protected]>
Date:   Thu Oct 16 18:48:28 2025 -0700

    Cleaning up viewmodel

Author: azeppenfeld <[email protected]>
Date:   Mon Oct 13 14:02:50 2025 -0700

    Added ability to change material colors and other properties

Author: azeppenfeld <[email protected]>
Date:   Thu Oct 2 18:30:49 2025 -0700

    Added ability to rotate, scale, and change the offset of a GLTF

Author: azeppenfeld <[email protected]>
Date:   Wed Oct 1 13:26:55 2025 -0700

    upgrading to alpha07 and a few other minor changes

    Adding bugdroid controller

Author: azeppenfeld <[email protected]>
Date:   Fri Sep 19 13:23:11 2025 -0700

    Added start/stop animation when BugDroid is shown

Change-Id: I8101c77c5510413074f57c3fc12261d3445ac067
@gemini-code-assist
Copy link

Summary of Changes

Hello @amyZepp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly upgrades the 'Hello Android XR' application by introducing a robust system for controlling a 3D Bugdroid model. It integrates a new ViewModel for managing UI state and provides interactive controls for manipulating the model's appearance and position, such as scale, rotation, offset, and material properties. This enhancement makes the application more interactive and showcases advanced capabilities of the Android XR framework.

Highlights

  • Enhanced Bugdroid Model Controls: Introduced comprehensive UI controls allowing users to dynamically adjust the Bugdroid 3D model's scale, rotation, offset, material colors, and material properties directly within the application.
  • New Bugdroid Controller and ViewModel: Added BugdroidController for efficient GLTF model loading and caching, and BugdroidViewModel to manage the UI state and logic for all Bugdroid model interactions, improving separation of concerns.
  • Dynamic Model Transformations and Materials: The BugdroidModel composable now applies dynamic transformations (scale, rotation, offset) and material properties (color, ambient occlusion, metallic, roughness) based on user input from the new UI controls.
  • UI Component Refactoring: Refactored the main HelloAndroidXRApp to integrate the new ViewModel and control components, and moved TextPane.kt into a dedicated ui/components package.
  • Dependency Updates: Updated several AndroidX XR and Android Gradle Plugin (AGP) dependencies to their latest alpha versions, including androidx-runtime, compose, extensionsXr, and scenecore.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 24, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This is a substantial and well-executed update that refactors the application to use a ViewModel with a unidirectional data flow, which greatly improves state management and overall architecture. The addition of controls for manipulating the Bugdroid model's properties is a great new feature. My review includes a few suggestions to address a critical issue with model caching and session handling, improve state validation within the ViewModel, and enhance code clarity and maintainability.

@amyZepp
minor changes
e7f5aa5 
Change-Id: Ie6d09c7d8a2860dc3cbc848a2a5c329a680e7461
@fuentespatrick fuentespatrick merged commit 54993ab into android:main Oct 26, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fuentespatrick fuentespatrick fuentespatrick approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amyZepp @fuentespatrick