Fix memory leak #446
Closed
Fix memory leak #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts and optimized code logic
…-leak # Conflicts: # core/core/src/main/java/androidx/core/app/ActivityCompat.java
alanv
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-merging this PR, but properly via copybara this time :)
Hello, there will be a memory leak when calling activity.shouldShowRequestPermissionRationale in Android 12. The problem is fixed in Android 12L, but it is still a legacy in Android 12. It is recommended to reflect the application.shouldShowRequestPermissionRationale method to avoid this problem.
Testing
Test: manually ran with LeakCanary
ActivityCompat.shouldShowRequestPermissionRationale(MainActivity.this, Manifest.permission.CAMERA);
finish();
Use leakcanary to view memory leaks
Fixes: 212113500
Fixes: 207946473
Fixes: 204539732