Tags: andyfenggq/ari
Tags
Allow subscription to all events (CyCoreSystems#102) Allows the websocket to be created with the subscribeAll flag set, to read events outside the scope of the specified ARI application.
Add AddChannelWithOptions (CyCoreSystems#101) Adds support for additional options to be passed when adding a channel to a bridge. Fixes CyCoreSystems#100
Originate: change key to referenceKey (CyCoreSystems#99) Having the "key" field to Originate and StageOriginate is confusing. It is easy to think that you should pass in the key for the channel you wish to create, rather than it being a completely optional "originator" key. Therefore, this patch changes the name of the variable to `referenceKey` so as to disambiquate the two, as well as offering an explanation in the comments.
[style] Do not mix implicit and explicit returns Addresses CyCoreSystems#93 readability
Merge pull request CyCoreSystems#91 from CyCoreSystems/issue-90 add MOH and StopMOH to bridge
Ignored error in StageOriginate? (CyCoreSystems#89) * Ignored error in StageOriginate? If I read it correctly, we're currently returning nil here regardless of whether there is an error when doing originate or not. Shall we instead return the same value that we get from c.client.post(...)? I tested by originating to unreachable destinations and the original version did not return an error, while the proposed one did. Please let me know if any more details could be helpful. Thanks!
PreviousNext