Remove public fields #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49e02e0 to
780c117
Compare
780c117 to
39a7397
Compare
lukaszcz
approved these changes
Jul 15, 2025
Collaborator
lukaszcz
left a comment
There was a problem hiding this comment.
Yes, this simplifies things!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr removes public fields from Object, Label and AppData.
In practice, we were never using public fields. In theory they were meant as an abstraction to add information into AppData. However, the information should be associated with each class member rather than the object itself.
Whether we need this abstraction is not entirely clear yet.