Use the label field to store Intent.ResourceData
#44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lukaszcz
commented
Jul 16, 2025
- Closes Store intent resource data in the label instead of the value field #39
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors how Intent.ResourceData is stored by introducing a Intent.LabelData wrapper in the label field and adjusting resource construction and extraction accordingly.
- Introduce
Intent.LabelDatato combine the intent’s label and its resource data. - Update
Intent.toResourceto embedResourceDatainsideLabelDataand useUnitforvalue. - Refactor
fromResourcefunctions and translation logic to extract data from the newLabelData.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| AVM/Intent.lean | Added Intent.LabelData, updated toResource and fromResource to use the label field. |
| AVM/Class/Translation.lean | Updated intent logic to extract and validate LabelData instead of raw ResourceData. |
Comments suppressed due to low confidence (2)
AVM/Intent.lean:41
- [nitpick] Consider adding a docstring for the
datafield inIntent.LabelDataexplaining that it contains the originalIntent.ResourceDatato improve clarity.
data : Intent.ResourceData
AVM/Intent.lean:64
- Consider adding unit tests for
Intent.LabelData.fromResourceandIntent.ResourceData.fromResourceto verify that resources are correctly encoded in the label and can be round-tripped.
def Intent.LabelData.fromResource (res : Anoma.Resource.{u,v}) : Option Intent.LabelData.{u} :=
janmasrovira
approved these changes
Jul 16, 2025
janmasrovira
added a commit
that referenced
this pull request
Jul 18, 2025
commit 4b9457b Author: Jan Mas Rovira <[email protected]> Date: Fri Jul 18 09:44:49 2025 +0200 add keys commit 0695dd3 Author: Jan Mas Rovira <[email protected]> Date: Fri Jul 18 08:00:17 2025 +0200 action commit 9c21534 Author: Jan Mas Rovira <[email protected]> Date: Thu Jul 17 22:01:49 2025 +0200 Logic commit c0c6d22 Author: Jan Mas Rovira <[email protected]> Date: Thu Jul 17 18:41:41 2025 +0200 more refactors commit bcaa410 Author: Jan Mas Rovira <[email protected]> Date: Thu Jul 17 17:30:49 2025 +0200 refactor files commit 5bb96be Author: Jan Mas Rovira <[email protected]> Date: Thu Jul 17 15:47:59 2025 +0200 adapt examples commit 0e0cdf6 Author: Jan Mas Rovira <[email protected]> Date: Thu Jul 17 13:19:14 2025 +0200 label for intents commit eae64cf Author: Jan Mas Rovira <[email protected]> Date: Thu Jul 17 10:06:38 2025 +0200 logic checks commit 7155377 Author: Jan Mas Rovira <[email protected]> Date: Wed Jul 16 22:32:16 2025 +0200 move intents out commit e0882f4 Author: Jan Mas Rovira <[email protected]> Date: Wed Jul 16 22:15:20 2025 +0200 function logic commit 2051950 Author: Jan Mas Rovira <[email protected]> Date: Wed Jul 16 14:37:26 2025 +0200 more changes commit 9e8ca17 Author: Jan Mas Rovira <[email protected]> Date: Tue Jul 15 19:14:04 2025 +0200 ecosystem wip commit 4d809d0 Author: Łukasz Czajka <[email protected]> Date: Wed Jul 16 15:47:23 2025 +0200 Use the `label` field to store Intent.ResourceData (#44) - Closes #39 commit 3db1b8e Author: Łukasz Czajka <[email protected]> Date: Wed Jul 16 06:42:20 2025 +0200 Compliance units (#43) - Closes #10 - The translation is modified to divide each action into compliance units. Dummy ephemeral resources with quantity 0 are added to satisfy the requirement that each compliance unit needs to have one consumed and one created resource. - The RLs are updated to filter out (ignore) the dummy resources. --------- Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.