Intent labels #55
Intent labels #55
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces global Intent labels to replace ecosystem-local intent IDs, addressing issue #48. The change moves from a system where intents were uniquely associated with ecosystems to one where intents have global labels and classes define which intent labels they allow.
Key changes:
- Introduction of global
Intent.Labelstructure with global scope - Replacement of ecosystem-level
IntentIdwith class-levelintentLabelssets - Refactoring of intent-related functions to use the new label system
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
AVM/Intent/Label.lean |
New file defining the global Intent.Label structure |
AVM/Intent.lean |
Refactored Intent structure to be parameterized by Intent.Label |
AVM/Class/Label.lean |
Added intentLabels field and intentId member type |
AVM/Class.lean |
Added intents field to Class structure |
AVM/Ecosystem/Label.lean |
Removed IntentId and related functionality |
AVM/Ecosystem.lean |
Removed intents field from Ecosystem structure |
Apps/UniversalCounter.lean |
Updated to use new intent system |
Apps/OwnedCounter.lean |
Updated to use new intent system |
Applib.lean |
Updated noIntents macro for new system |
AVM/Intent/Translation.lean |
Updated function signatures for new Intent parameterization |
AVM/Ecosystem/Translation.lean |
Removed old intent logic handling |
AVM/Class/Translation.lean |
Added new intent logic handling at class level |
Comments suppressed due to low confidence (1)
| @@ -0,0 +1,19 @@ | |||
|
|
|||
There was a problem hiding this comment.
I've noticed that we sometimes have an empty line at the beginning of a file. Is that intentional?
There was a problem hiding this comment.
Not very. It just somehow seemed to me more natural to put an empty line before imports, but we can agree on not doing it if you prefer.
There was a problem hiding this comment.
I don't care much, but if we want to be uniform, I'd prefer no empty line
Uh oh!
There was an error while loading. Please reload this page.