Fix computation of nonces #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the computation of nonces in the AVM system by properly generating and using random nonces (for consumed ephemeral resources) or nullifiers of corresponding consumed resources (for created resources). The changes ensure that each resource creation gets a unique, properly generated nonce value.
- Removes the default parameter for nonces in
Intent.toResourceto make nonce generation explicit - Updates the nonce generation logic in
Intent.action'to generate proper nonces - Refactors created object handling to defer nonce computation until action creation
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| AVM/Intent/Translation.lean | Updates nonce generation to use proper random values and fixes variable naming |
| AVM/Intent.lean | Removes default nonce parameter to enforce explicit nonce passing |
| AVM/Ecosystem/Translation.lean | Removes todo nonce placeholder from created objects |
| AVM/Class/Translation.lean | Simplifies created object construction by removing manual nonce handling |
| AVM/Action.lean | Refactors created object structure and moves nonce computation to action creation time |
Comments suppressed due to low confidence (3)
AVM/Intent/Translation.lean:61
- [nitpick] The variable name 'r1' is not descriptive. Consider renaming to 'nonce1' or 'randomValue1' to clarify its purpose.
let (r1, g2) := stdNext g1
AVM/Intent/Translation.lean:62
- [nitpick] The variable name 'r2' is not descriptive. Consider renaming to 'nonce2' or 'randomValue2' to clarify its purpose.
let (r2, g3) := stdNext g2
AVM/Intent/Translation.lean:63
- [nitpick] The variable name 'r3' is not descriptive. Consider renaming to 'nonce3' or 'randomValue3' to clarify its purpose.
let (r3, g4) := stdNext g3
janmasrovira
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nonce computation: