Fix nonce and rcv computation #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues with nonce computation for intent resources and random value generation for compliance witnesses. The changes ensure that nonces are properly derived from nullifiers of ephemeral consumed resources, and that different random numbers are used for rcv fields in created resources.
- Fixed nonce computation in Intent translation to use nullifier from ephemeral consumed resource
- Refactored random value generation to ensure unique
rcvvalues - Updated random number generator state management to prevent reuse
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| AVM/Intent/Translation.lean | Updates nonce computation to derive from nullifier and fixes random number generator usage |
| AVM/Action.lean | Refactors compliance witness creation to generate unique random values per witness |
Comments suppressed due to low confidence (2)
AVM/Intent/Translation.lean:63
- [nitpick] The variable name 'res' is too generic and unclear. Consider renaming it to 'ephemeralResource' or 'consumedResource' to better reflect its purpose in nonce computation.
let res := dummyResource ⟨r1⟩
AVM/Intent/Translation.lean:64
- [nitpick] The variable name 'can_nullify' uses snake_case which appears inconsistent with the camelCase naming convention used elsewhere in the codebase (e.g., 'createdWitness', 'intentResource').
let can_nullify := Anoma.nullifyUniversal res Anoma.NullifierKey.universal rfl rfl
a8b9f24 to
7e3c01b
Compare
janmasrovira
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Action.create: they should be different random numbers.